[HOLD for payment 2023-12-29] Android - Distance - Location permission prompt reappears after declining it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #30506

Action Performed:

Precondition:

• The device used is a Samsung device with Android 12.
• App location permission is reset.

1. Launch New Expensify app.
2. Tap + > Request money > Distance.
3. Don't allow location access.
4. Wait for a while.

Expected Result:

Location permission prompt will not reappear.

Actual Result:

Location permission prompt appears again.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293229_1701179208961.Screen_Recording_20231128_142647_Permission_controller.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

Pinged @neil-marcellini here in Slack since he's been working on this feature

[neil-marcellini]

Here is the PR that caused this Automatically pan initial map based on current location. It's not reproducible on production because this is a new feature. I don't think it's a significant enough issue to be worth blocking deploy. If you agree I'll remove the label. Let's start looking into a fix regardless.