Skip to content

HIGH: [Polish] [$500] Finalize order of LHN in #focus mode #33029

@quinthar

Description

@quinthar

Problem:
When the LHN is in "focus" mode, its sorting should be:

  1. All pinned reports, alphabetically
  2. Everything else, alphabetically

However, it doesn't seem to be. Here's from @iwiznia:

Image

Solution:
Review the LHN logic for sorting in focus mode to understand what it's currently doing, and verify it's correct. The correct behavior should be:

#focus mode:

  • All pinned chats (alphabetically)
  • Everything else (alphabetically)

most recent mode:

  • All pinned chats (alphabetically)
  • Everything else (most recent sorting)

Additionally:

  • When sorting alphabetically, it should only sort the alphanumeric characters -- other characters should be ignored.
  • "pinned chats" refers to chats that are actually pinned, as well as any chat with a "green/red brick road" (GBR/RBR), which are treated as if they are pinned.

So, for this issue please:

  1. Review the existing sorting code
  2. Update it to match the logic above
  3. Update the sort comparator to ignore non-alphanumeric characters when sorting
  4. Verify that GBR chats are showing as pinned
  5. Verify that RBR chats are showing as pinned

You up to the challenge? Let's see those proposals!!

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01432274cc2b58438c
  • Upwork Job ID: 1744194942807576576
  • Last Price Increase: 2024-01-08
Issue OwnerCurrent Issue Owner: @youssef-lr

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffMonthlyKSv2Not a priorityReviewingHas a PR in reviewTask

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions