[HOLD for payment 2024-02-05] [$500] IOU - Amount is not preserved in Manual page when the amount is changed in confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.13.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Click FAB > Request money > Manual.
3. Enter amount and select a participant.
4. On the confirmation page, click Amount.
5. Change the amount and save it.
6. Click on the back button twice to return to Manual page.

Expected Result:

The new amount is preserved in Manual page

Actual Result:

The new amount is not preserved in Manual page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313586_1702585393338.20231214_195558.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100d59ba09cfb0bc4
• Upwork Job ID: 1735420492994256896
• Last Price Increase: 2024-01-04
• Automatic offers:
• situchan | Reviewer | 28088789
• mkhutornyi | Contributor | 28088790

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100d59ba09cfb0bc4

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount is not preserved in Manual page when the amount is changed in confirmation page

What is the root cause of that problem?

This happens as on the MoneyRequestAmountForm the amount is calculated from selectedAmountAsString variable

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Lines 79 to 81 in 06662fa

	const selectedAmountAsString = amount ? CurrencyUtils.convertToFrontendAmount(amount).toString() : '';
	const [currentAmount, setCurrentAmount] = useState(selectedAmountAsString);

When we navigate back to this page, the selectedAmountAsString variable changes, but since the screen was already mounted, the state currentAmount still has the old amount, which is reflected on the page.

Video: This can be clearly seen when we log both variables

7ea2240d-791e-4975-87b4-db5e678ac0a8.mp4

What changes do you think we should make in order to solve the problem?

We should add a useEffect that updates the current amount when selectedAmountAsString changes.

     useEffect(() => { 
        setCurrentAmount(selectedAmountAsString);
    }, [selectedAmountAsString, setCurrentAmount]);

Result

c5846578-4c56-468a-adcd-5fb359be318b.mp4

[Krishna2323]

Can't reproduce on latest main branch.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Amount is not preserved in Manual page when the amount is changed in confirmation page

What is the root cause of that problem?

We have logic of updating amount but only when tab is changed:

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Lines 121 to 128 in 9d2ea87

	useEffect(() => {
	if (!currency || !_.isNumber(amount)) {
	return;
	}
	initializeAmount(amount);
	// we want to re-initialize the state only when the selected tab changes
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [selectedTab]);

What changes do you think we should make in order to solve the problem?

add amount to dependency

---

This also fixes #33123 which has the same root cause:
Amount is cleared here

App/src/pages/iou/request/IOURequestStartPage.js

Lines 82 to 87 in 9d2ea87

	// Clear out the temporary money request if the reportID in the URL has changed from the transaction's reportID
	useEffect(() => {
	if (transaction.reportID === reportID) {
	return;
	}
	IOU.startMoneyRequest_temporaryForRefactor(reportID, isFromGlobalCreate, transactionRequestType.current);

But not updated because of useEffect without amount dependency