[$125] Request money - The 'Enter' key fails to select the email/workspace/phone when requesting money.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Sign in to staging Expensify
2. Navigate to FAB > Request Money > Add amount, then press 'Enter' to select the email. Observe that the 'Enter' key does not work as expected

Expected Result:

The 'Enter' key should successfully select the email during the request for money

Actual Result:

The 'Enter' key does not select the email as intended during the request for money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337734_1704896732715.Screen_Recording_2024-01-10_at_5.12.27_AM.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't select a participant with the enter key.

What is the root cause of that problem?

This is a regression from #31354.

When we select a participant, we return early if the screen is not focused.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 335 to 341 in 55746c7

	selectFocusedOption(e) {
	const focusedItemKey = lodashGet(e, ['target', 'attributes', 'id', 'value']);
	const focusedOption = focusedItemKey ? _.find(this.state.allOptions, (option) => option.keyForList === focusedItemKey) : this.state.allOptions[this.state.focusedIndex];
	if (!focusedOption || !this.isFocused) {
	return;
	}

isFocused value initially is false.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Line 87 in 55746c7

this.isFocused = false;

and updated true inside the focus listener, but focus listener is called only if the screen is re-focused, not when the page is mounted, so isFocused is always false.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 102 to 117 in 55746c7

	this.focusListener = this.props.navigation.addListener('focus', () => {
	// Screen coming back into focus, for example
	// when doing Cmd+Shift+K, then Cmd+K, then Cmd+Shift+K.
	// Only applies to platforms that support keyboard shortcuts
	if ([CONST.PLATFORM.DESKTOP, CONST.PLATFORM.WEB].includes(getPlatform())) {
	this.subscribeToKeyboardShortcut();
	}
	if (this.props.autoFocus && this.textInput) {
	this.focusTimeout = setTimeout(() => {
	this.textInput.focus();
	}, CONST.ANIMATED_TRANSITION);
	}
	this.isFocused = true;
	});

What changes do you think we should make in order to solve the problem?

We can set the initial value of isFocused to true, but we still need to duplicate the code from the focus listener to the componentDidMount

isFocused is actually not needed because we already unsubscribe the shortcut when component blurs

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[youssef-lr]

I think this can be demoted.