[HOLD for payment 2024-02-19] [$500] IOU -Deleting submitted report shows unexpected error with amount crossed out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Login employee account
3. Tap on employee workspace chat
4. Tap plus icon near compose-- request money manual
5. Enter an amount and tap next
6. Enter merchant field
7. Tap request
8. Tap submit
9. Open submitted IOU to open IOU detail page
10. Tap 3 dots on top right and tap delete and confirm delete request

Expected Result:

User must not be shown option/allowed to delete submitted report & error should not be displayed with amount crossed out

Actual Result:

In employee WS, create manual request and submit it. User shown option/allowed to delete submitted report and deleted report shows unexpected error with amount crossed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343590_1705353673385.rep.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165e8908305facf78
• Upwork Job ID: 1747014776873512960
• Last Price Increase: 2024-01-22
• Automatic offers:
• s77rt | Reviewer | 28134406
• bernhardoj | Contributor | 28134407

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165e8908305facf78

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting a submitted money request gives an error.

What is the root cause of that problem?

We are not hiding the delete button when the money request is submitted. We only hide it if it's approved or settled.

App/src/components/MoneyRequestHeader.js

Line 88 in 8e2fb67

const canModifyRequest = isActionOwner && !isSettled && !isApproved && !ReportActionsUtils.isDeletedAction(parentReportAction);

What changes do you think we should make in order to solve the problem?

We need to hide it if the money request is submitted. To know whether it's submitted or not, we can use the same check-in #32796, specifically:

App/src/libs/ReportUtils.ts

Lines 3815 to 3818 in 8e2fb67

	const isOwnExpenseReport = isExpenseReport(report) && isOwnPolicyExpenseChat;
	if (isOwnExpenseReport && PolicyUtils.isPaidGroupPolicy(policy)) {
	return isDraftExpenseReport(report);
	}

We only check the submitted status (isDraftExpenseReport true means open, not submitted) in an expense report that is linked with a paid policy.

We need to apply this check in both MoneyRequestHeader and in ReportUtils.canDeleteReportAction.

App/src/libs/ReportUtils.ts

Lines 1139 to 1141 in 8e2fb67

	if (isActionOwner) {
	return true;
	}

if (isActionOwner) {
    if (isExpenseReport(report) && PolicyUtils.isPaidGroupPolicy(policy)) {
        return isDraftExpenseReport(report);
    }
    return true;
}

App/src/components/MoneyRequestHeader.js

Lines 115 to 119 in 8e2fb67

	threeDotsMenuItems.push({
	icon: Expensicons.Trashcan,
	text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
	onSelected: () => setIsDeleteModalVisible(true),
	});

if (ReportUtils.isExpenseReport(moneyRequestReport) && PolicyUtils.isPaidGroupPolicy(policy)) {
    if (ReportUtils.isDraftExpenseReport(moneyRequestReport)) {
        threeDotsMenuItems.push({
            icon: Expensicons.Trashcan,
            text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
            onSelected: () => setIsDeleteModalVisible(true),
        });
    }
} else {
    threeDotsMenuItems.push({
        icon: Expensicons.Trashcan,
        text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
        onSelected: () => setIsDeleteModalVisible(true),
    });
}

[0xmiroslav]

@sakluger once submitted (but not approved yet), request should not be deletable? I believe so but just to confirm

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sakluger]

I'm checking on correct expected behavior in Slack: https://expensify.slack.com/archives/C02MW39LT9N/p1706052284329559