[HOLD for payment 2024-02-19] [$500] IOU - IOU Preview and header are not grayed out when pay IOU in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Navigate to a conversation that the user owes money to the other participant
3. Disable the internet connection in the device
4. Tap on the Pay button in the IOU preview

Expected Result:

The IOU Preview and the top of the modal should be greyed out

Actual Result:

IOU Preview and header are not grayed out when pay IOU in offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6347840_1705682986102.az_recorder_20240118_184452.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0148717463252090bf
• Upwork Job ID: 1748394308536238080
• Last Price Increase: 2024-01-19
• Automatic offers:
• cubuspl42 | Reviewer | 28131193
• dukenv0307 | Contributor | 28131194

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0148717463252090bf

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU Preview and header are not grayed out when pay IOU in offline mode

What is the root cause of that problem?

Actually, when we pay the IOU, we are not setting any pending action for IOU action or report preview. We only set pendingAction for pay action as it's a new action

What changes do you think we should make in order to solve the problem?

• First, I think we should discuss what preview we want to gray out when we pay IOU in offline

1. If we want to show grey out for report preview, we can add preview pendingFields for IOUReport optimistic data as the same way we do when we add a new request

App/src/libs/actions/IOU.js

Line 376 in 56fb814

...(isNewIOUReport ? {createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD} : {preview: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE}),

2. If we want to show grey out for IOU action preview we can add a new pendingField like reimbursed for IOUReport optimistic data when we pay the IOU and then use this to add pendingAction for OfflineWithFeedback in MoneyRequestPreview. Since we also have a OfflineWithFeedback in ReportActionItem, we also need to add disable opacity for OfflineWithFeedback of MoneyRequestPreview if action.pendingAction exists.

• For the header of the IOU report I don't think we need to grey out this. If we also want to grey out the header we can use reimbursed pendingField above and return it in getReportOfflinePendingActionAndErrors function. With this,, report screen of IOU report will be greyed out so we don't need to add any more pendingAction in MoneyRequestPreview. But I still think not grey out header is better.

What alternative solutions did you explore? (Optional)

NA

[DheerajKhush]

How I can contribute?

[melvin-bot]

📣 @DheerajKhush! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

I am not sure if the expected behaviour of greying out the preview will help here as the user would want to go through the IOU details even when offline. To me, it looks like the problem is that the user is able to pay even when offline which does not seem correct.

What is the root cause of that problem?

Here, we check if the settlement button should be disabled. However, we do not disable the settlement button when offline. This is the root cause.

What changes do you think we should make in order to solve the problem?

To fix the problem, we can additionally check for offline condition as following here

       isDisabled={isDisabled || isOffline}

What alternative solutions did you explore? (Optional)

[rojiphil]

I am not sure if the expected behavior of greying out the preview will help here as the user would want to go through the IOU details even when offline. To me, it looks like the problem is that the user is able to pay even when offline which does not seem correct.

@cubuspl42 @stephanieelliott
Can you please reconfirm the expected behavior in this issue?