[$500] IOU - New green line appears when delete second IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.4.32-2
**Reproducible in staging?:**Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34011

Action Performed:

1. Go to FAB> Request money>
2. Request money from a user that has no existing chat
3. Click on + button> Request Money> Complete the IOU flow
4. Delete the last created IOU
5. Navigate back to the conversation

Expected Result:

Green line should not appears since there is no new message

Actual Result:

New green line appears when delete second IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355252_1706223349466.Recording__1926.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa6428b2af1b32c9
• Upwork Job ID: 1750655802310635520
• Last Price Increase: 2024-01-25

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa6428b2af1b32c9

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New green line appears when delete second IOU

What is the root cause of that problem?

When we delete the money request, the created field of the REPORTPREVIEW report action is not set correctly.

When we create a money request here, the created of the REPORTPREVIEW will be updated to current timestamp, this is because we want the REPORTPREVIEW to show up as latest message in the main chat report, so the user will notice.

So let's say the main chat has:
1 REPORTPREVIEW: At Jan 24 (initial money request is at Jan 24)
1 comment "What's up": At Jan 25

After the user creates a new money request on Jan 26, the REPORTPREVIEW will jump to Jan 26 and become the latest message. This is correct:

1 comment "What's up": At Jan 25
1 REPORTPREVIEW: At Jan 26

But when deleting a money request that we just created, we don't do anything to the REPORTPREVIEW report action's created time, see here, we revert everything to the previous value before that money request is created, but the created field remains the same.

So after deletion, it will still look like:
1 comment "What's up": At Jan 25
1 REPORTPREVIEW: At Jan 26

Which is wrong, because now when the user clicks on the report preview, they will only see 1 initial money request from Jan 24, and have no idea why they see a report preview on Jan 26 but in the iou report itself, there's nothing happening on Jan 26.

If the user is online, the back-end will send back a created field that is of current timestamp, as if the REPORTPREVIEW was recently created. That timestamp is larger than the last read time of the chat report, so the new green line shows.

What changes do you think we should make in order to solve the problem?

When deleting a money request, we need to revert the created of the report preview to the created time of the latest money request (amongst the remaining ones) in the IOU report. This needs to be done in optimistic data and in back-end as well.

There're some fields in the iouReport that might need to be reverted to that timestamp as well, like lastVisibleActionCreated.

What alternative solutions did you explore? (Optional)

NA

[cjoshidev]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The new green line appears when deleting second IOU

What is the root cause of that problem?

For displaying the new line marker we have a prop shouldDisplayNewMarker which is a combination of a lot of conditions.

To not display the green line we need to remove , i have tested and it wont impact any other things in the App and it will fix the issue as well

_.isEqual(prevProps.report.isDeletedParentAction, nextProps.report.isDeletedParentAction)

What changes do you think we should make in order to solve the problem?

Need to remove the condition i have specified above to make sure it is fixed

What alternative solutions did you explore? (Optional)

NA

[twisterdotcom]

Gonna put this in #vip-vsp then. @jjcoffee, @dukenv0307 and @cjoshi-zeals - are sure this shouldn't be a BE change like #34190 as well?