[HOLD for payment 2024-03-13] [$500] mWeb - Welcome to Expensify is shown for existing user after logging in from public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause -Internal Team
Slack conversation:

Action Performed:

1. Log out of New Expensify
2. Navigate to this link - https://staging.new.expensify.com/r/5408450846930023
3. Click on Sign In
4. Login in with an existing account

Expected Result:

Public room chat history should be displayed.
Welcome to Expensify message should be either shown before logging in or not at all for existing users

Actual Result:

Welcome to Expensify screen is shown after log in, user is forced to close it to view public room chat history

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362919_1706736644415.Record_2024-01-31-20-50-10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01adefc3ca63c114f2
• Upwork Job ID: 1752868613105299456
• Last Price Increase: 2024-02-15
• Automatic offers:
• situchan | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01adefc3ca63c114f2

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Engagement modal is shown while visiting a public room via deep link as an anonymous user.

What is the root cause of that problem?

The check for showing engagement model is performed inside BottomTabBar in a useEffect.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Line 55 in 3e77445

Welcome.show(routes, () => Navigation.navigate(ROUTES.ONBOARD));

Inside Welcome.show method, the engamement modal is shown if current user is isFirstTimeNewExpensifyUser.

App/src/libs/actions/Welcome.ts

Lines 130 to 132 in 3e77445

	if (!isFirstTimeNewExpensifyUser) {
	return;
	}

App/src/libs/actions/Welcome.ts

Lines 171 to 173 in 3e77445

	if (!Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) {
	showEngagementModal();
	}

However the above check doesn't consider whether the current user is an anonymous user. That's why the engagement modal gets shown for anonymous user.

What changes do you think we should make in order to solve the problem?

Check if current user is an anonymous user before showing engagement modal.

// Add check for anonymous user
if (!Session.isAnonymousUser() && !Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) {
  showEngagementModal();
}

What alternative solutions did you explore? (Optional)

None

[sakluger]

I asked in #vip-vsb if this is a bug or expected behavior: https://expensify.slack.com/archives/C066HJM2CAZ/p1707178252015419