[HOLD for payment 2024-03-13] [$500] [MEDIUM] "Concierge" is displayed in LHN and thread header for Concierge approval message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v.1.3.45-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• Employee are part of the Collect workspace.
• Schedule submit is enabled (Daily).

1. Go to workspace chat.
2. Create a distance request,
3. Go to expense report.
4. Click Submit.
5. Refresh the page.
6. Note that expense report preview in LHN.
7. Right click on the Concierge final approve message > Reply in thread.

Expected Result:

In Step 6, the preview in LHN will show the complete message.
In Step 7, the thread header will show the complete message.

Actual Result:

In Step 6, LHN preview shows just "Concierge".
In Step 7, the thread header shows just "Concierge" instead of complete Concierge final approve message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6364626_1706867177978.20240202_114341.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184792cdee67cc75a
• Upwork Job ID: 1753407551107751936
• Last Price Increase: 2024-02-02
• Automatic offers:
• akinwale | Reviewer | 28150317
• FitseTLT | Contributor | 28150318

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0184792cdee67cc75a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Concierge" is displayed in LHN and thread header for Concierge approval message

What is the root cause of that problem?

Currently when we submit the lastmessageText of the report is set to message.0.text ( but BE sets lastmessageText to the submitter like in this case "Concierge")

App/src/libs/actions/IOU.js

Lines 3364 to 3365 in 9d4c634

	lastMessageText: lodashGet(optimisticSubmittedReportAction, 'message.0.text', ''),
	lastMessageHtml: lodashGet(optimisticSubmittedReportAction, 'message.0.html', ''),

And the alternateText for the LHN will be set to lastMessageText here

App/src/libs/OptionsListUtils.ts

Lines 569 to 570 in 9d4c634

	return lastMessageTextFromReport || (report?.lastMessageText ?? '');
	}

And the problem with the thread header is in the logic here

App/src/libs/ReportUtils.ts

Lines 2332 to 2333 in 9d4c634

	const parentReportActionMessage = (parentReportAction?.message?.[0]?.text ?? '').replace(/(\r\n|\n|\r)/gm, ' ');
	if (isAttachment && parentReportActionMessage) {

we are setting it to parentReportAction?.message?.[0]?.text

What changes do you think we should make in order to solve the problem?

We have two options to solve it

1. set the lastmessageText by iterating and joining reportAction.message here and of course in BE
   

   App/src/libs/actions/IOU.js

   Lines 3364 to 3365 in 9d4c634

   	lastMessageText: lodashGet(optimisticSubmittedReportAction, 'message.0.text', ''),
   	lastMessageHtml: lodashGet(optimisticSubmittedReportAction, 'message.0.html', ''),

2. To change the logic we use in OptionsListUtils.getLastMessageTextForReport for SUBMITTED type lastReportAction and set it to content of reportAction.message joined together.

Now to deal with the thread header we need to change the logic here

App/src/libs/ReportUtils.ts

Lines 2332 to 2333 in 9d4c634

	const parentReportActionMessage = (parentReportAction?.message?.[0]?.text ?? '').replace(/(\r\n|\n|\r)/gm, ' ');
	if (isAttachment && parentReportActionMessage) {

So when the parentReportAction is SUBMITTED type we need to do the same as above: iterate through message and join it.

What alternative solutions did you explore? (Optional)