[HOLD for payment 2024-03-26] [HOLD on E/E #347391][$500] [HIGH] for Collect: Show "Unapprove" report action in NewDot

[Beamanator]

Related to https://github.com/Expensify/Expensify/issues/364085

Flow:

Pre-testing steps

1. Create a new collect policy on OldDot and;
   1. Enable scheduled submit with a frequency of Instant (this should happen by default with Expensify accounts, or accounts on paidPolicyInstantSubmit beta)
   2. Make sure the approval mode is "Submit & Approve"
   3. Invite an additional user to the policy to play the member role in these testing flows
2. Run the following script in the chrome console (in OldDot, when the workspace Settings page is open) to enable the policy for workspace creation for a paid plan.

   p = Policy.getCurrent();
   p.policy.isPolicyExpenseChatEnabled = "true";
   p.save();
   

Test steps

1. In OldDot: As submitter, make sure ^ new workspace is your "Active" / default workspace
2. In OldDot: As submitter, create a report and add an expense
3. In OldDot: As Admin, approve the report - then Unapprove the report
4. In NewDot: As both accounts, view the expense report & verify you can see both of these report actions:
   1. <admin> final approved this report
   2. <admin> unapproved this report

Currently we're blocked on 4 ^ - the <admin> unapproved this report report action does not appear, even though the report action exists in Onyx

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012cccf392c943b52d
• Upwork Job ID: 1755224934075211776
• Last Price Increase: 2024-02-07

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012cccf392c943b52d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[Beamanator]

Getting some feedback in slack first - internal channel - https://expensify.slack.com/archives/C02NZ2HGJAZ/p1707314650284219

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The UNAPPROVED action is not currently shown in the collect workspace in NEWDOT when an APPROVED report is unapproved.

What is the root cause of that problem?

Here we filter the type of actions that needs to be displayed. Currently, we only include APPROVED and SUBMITTED. Since we have not included UNAPPROVED action, this is not displayed.

What changes do you think we should make in order to solve the problem?

We can solve this problem by adding another constant here for UNAPPROVED and update the line here like this to include UNAPPROVED action.

const isApprovedOrSubmittedReportAction = [CONST.REPORT.ACTIONS.TYPE.UNAPPROVED, CONST.REPORT.ACTIONS.TYPE.APPROVED, CONST.REPORT.ACTIONS.TYPE.SUBMITTED].some((type) => type === action.actionName);

We may also want to change the usage of variable isApprovedOrSubmittedReportAction to something more generic than specific.

What alternative solutions did you explore? (Optional)

[Beamanator]

So far I like this plan ^ but I'm also waiting on a few internal discussions to wrap up before we move forward here