[Hold for payment 2024-03-06] [$500] Tag - Selected tag is missing in Split report when split scan is created offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.39.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35913

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has tags.

1. Go to workspace chat.
2. Go offline.
3. Click + > Split bill > Scan.
4. Create a scan request.
5. Click on the split preview.
6. Enter amount, merchant and select a tag.
7. Click Split.
8. Navigate to split report.

Expected Result:

The selected tag appears on Tag row.

Actual Result:

The Tag row is missing the selected tag.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6373664_1707488765500.20240209_034402.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174fb7f86a4edd9a2
• Upwork Job ID: 1755965144915570688
• Last Price Increase: 2024-02-09
• Automatic offers:
• paultsimura | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0174fb7f86a4edd9a2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related to #vip-split-p2p-chat-groups
CC @gabrielessner

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When completing the scan split manually, the tag & category are not updated optimistically in the individual transactions.

What is the root cause of that problem?

When completing the Split Bill, we do not pass the updated category & tag for each individual IOU transaction:

App/src/libs/actions/IOU.ts

Lines 2231 to 2242 in ad3d78c

	const oneOnOneTransaction = TransactionUtils.buildOptimisticTransaction(
	isPolicyExpenseChat ? -splitAmount : splitAmount,
	currency ?? '',
	oneOnOneIOUReport?.reportID ?? '',
	updatedTransaction.comment.comment,
	updatedTransaction.modifiedCreated,
	CONST.IOU.TYPE.SPLIT,
	transactionID,
	updatedTransaction.modifiedMerchant,
	{...updatedTransaction.receipt, state: CONST.IOU.RECEIPT_STATE.OPEN},
	updatedTransaction.filename,
	);

What changes do you think we should make in order to solve the problem?

When completing the Split Bill, we need to pass the category & tag for each individual IOU transaction as well:

        const oneOnOneTransaction = TransactionUtils.buildOptimisticTransaction(
            isPolicyExpenseChat ? -splitAmount : splitAmount,
            currency ?? '',
            oneOnOneIOUReport?.reportID ?? '',
            updatedTransaction.comment.comment,
            updatedTransaction.modifiedCreated,
            CONST.IOU.TYPE.SPLIT,
            transactionID,
            updatedTransaction.modifiedMerchant,
            {...updatedTransaction.receipt, state: CONST.IOU.RECEIPT_STATE.OPEN},
            updatedTransaction.filename,
+            undefined,
+            updatedTransaction.category,
+            updatedTransaction.tag,
        );

Result:

Screen.Recording.2024-02-09.at.15.57.37-compressed.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...