[HOLD for payment 2024-03-19] [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [Workflows] Workflow - Weekly submission frequency is not selected by default

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): nathanmulugetatesting@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #37213

Action Performed:

1. Create a new Collect policy on OldDot
2. Enable the Collect workspace to show up on NewDot
3. Login to NewDot, then navigate to Settings > Workspaces. You should see your Collect workspace, click on it
4. Click on Workflows
5. Toggle the Submission frequency sub item. A submenu should open and observe the default value

Expected Result:

Weekly should be set as the default value

Actual Result:

No value is set as the default value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402902_1709649283440.submissionFrequencyBug.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[luacmartins]

cc @lakchote

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflow - Weekly submission frequency is not selected by default

What is the root cause of that problem?

The WorkspaceAutoReportingFrequencyPage component only finds the selected option if policy?.autoReportingFrequency is present.

App/src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx

Line 50 in 5199604

const isSelected = policy?.autoReportingFrequency === frequencyKey;

Therefore, if policy?.autoReportingFrequency is nullified, none of the options will be selected.

What changes do you think we should make in order to solve the problem?

Change the line above to also consider the default frequency which should be CONST.POLICY.AUTO_REPORTING_FREQUENCIES.WEEKLY when finding the selected option.

const isSelected = policy?.autoReportingFrequency ? 
 policy.autoReportingFrequency === frequencyKey : 
 CONST.POLICY.AUTO_REPORTING_FREQUENCIES.WEEKLY === frequencyKey;

[luacmartins]

Hmm I actually think the correct solution is to optimistically set weekly as the autoReportingFrequency