Scan - Detach receipt message mentions (none) as merchant for scan request with merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Create a scan request
4. Go to request details page
5. Manually enter amount and merchant
6. Click on the receipt > 3-dot menu > Delete receipt
7. Delete the receipt
8. Return to expense report

Expected Result:

The detach receipt message should mention the correct merchant that is entered in Step 5

Actual Result:

The detach receipt message mentions (none) as merchant instead of the entered merchant

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418398_1710796561306.20240319_051151.1.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[allgandalf]

regression from #38013

[NikkiWines]

Definitely comes from that PR, but I don't think this is technically a blocker. Pretty sure it's a byproduct of surfacing these Expensify Classic report actions on New Expensify. I see the same behavior if I repeat the test on Expensify Classic.

cc: @Beamanator (since you were involved in that linked PR) looks like we might have a bug in some of the Web report action code that's not retaining the merchant here