[HOLD for payment 2024-04-05] [Simplified Collect][Taxes] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37967
Issue reported by: Applause - Internal team

Action Performed:

Precondition: With a new expensifail account in OD, create a Collect workspace with workspace chat enabled.

1. In ND, log in with the same account
2. Navigate to Workspace settings - More features
3. Enable Taxes
4. Navigate to Workspace settings - Taxes
5. Tap on the "+ Add rate" button
6. Tap on the "Name" field

Expected Result:

The keyboard should be visible.

Actual Result:

Tax name field isn't auto focused, the keyboard isn't visible, only the cursor is shown. The keyboard appears if you tap inside the field.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418905_1710834758344.az_recorder_20240319_084531.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb504f048b994348
• Upwork Job ID: 1770073117296906240
• Last Price Increase: 2024-03-19
• Automatic offers:
• alitoshmatov | Reviewer | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

cc: @luacmartins

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax name field isn't auto focused, the keyboard isn't visible, only the cursor is shown. The keyboard appears if you tap inside the field.

What is the root cause of that problem?

We pass autoFocus props into tax name TextInput that makes the cursor appears but the keyboard doesn't appear

App/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx

Line 102 in 34fa987

autoFocus

What changes do you think we should make in order to solve the problem?

We should use useAutoFocusInput hook in TextSelectModal and pass the ref as inputCallbackRef here instead of passing autoFocus

App/src/components/TextPicker/TextSelectorModal.tsx

Line 41 in 34fa987

<TextInput

What alternative solutions did you explore? (Optional)

NA

[kosmydel]

I think it's a duplicate of this issue: #38497

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb504f048b994348