[ON-HOLD Payment 4/16] [$500] Android/iOS - Chat - New chat shows time zone for Unvalidated Accounts

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.54.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4434326
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app (used gmail)
2. Tap fab --- start chat
3. Enter 9894706467/+19894706461 (use non-existing local number
4. From suggestions, select the contact
5. Tap on the header

Expected Result:

New chat must not show time zone.

Actual Result:

User is not part of same private workspace/domain nor had sent a DM, yet time zone showing in details page for unvalidated accounts.

New chat shows time zone.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418748_1710821663189.hi.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebbabe514d6a178d
• Upwork Job ID: 1770142743565381632
• Last Price Increase: 2024-03-19
• Automatic offers:
• mollfpr | Reviewer | 0
• GandalfGwaihir | Contributor | 0

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Chat - New chat shows time zone.

What is the root cause of that problem?

We don't use canShowReportRecipientLocalTime for checking if to show local time or not.

App/src/pages/ProfilePage.tsx

Line 93 in 34fa987

const shouldShowLocalTime = !ReportUtils.hasAutomatedExpensifyAccountIDs([accountID]) && !isEmptyObject(timezone);

We do have a check in ReportActionCompose.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 177 to 180 in 34fa987

	const shouldShowReportRecipientLocalTime = useMemo(
	() => ReportUtils.canShowReportRecipientLocalTime(personalDetails, report, currentUserPersonalDetails.accountID) && !isComposerFullSize,
	[personalDetails, report, currentUserPersonalDetails.accountID, isComposerFullSize],
	);

What changes do you think we should make in order to solve the problem?

Add a check for canShowReportRecipientLocalTime also.

    const currentUserPersonalDetails = useCurrentUserPersonalDetails();

    const shouldShowLocalTime =
        !ReportUtils.hasAutomatedExpensifyAccountIDs([accountID]) &&
        !isEmptyObject(timezone) &&
        ReportUtils.canShowReportRecipientLocalTime(personalDetails, report, currentUserPersonalDetails.accountID);

We might also want to hide other fields like pronouns.

Result

Alternatively

Show local time above composer also.

[Krishna2323]

Proposal updated

[hayes102]

Don't think this is a bug actually

[melvin-bot]

📣 @hayes102! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[CortneyOfstad]

@kbecciv This is not a bug. We show timezones by default so people are aware of what time it is for the person they attempt to message. This is not personal information, and only provides a very broad location of where that person is at the moment the message is sent.

Going to close this 👍

[Krishna2323]

@CortneyOfstad, but why do we hide the local time above the composer than? Just want to confirm because we did intentionally hide the localtime above the composer.

[CortneyOfstad]

@Krishna2323 can you clarify what you mean by "the composer"? Sorry for the confusion on my part!

[CortneyOfstad]

@Krishna2323 I did some additional testing on this, and realized the "composer" refers to the text box — so all good there.

However, I am surprised that we would hide that information, as it is not private by any means. I'm going to bring this to the room to discuss further and will follow up 👍