[HOLD for payment 2024-05-09] [$250] Group chat - Chat header does not follow chat name in LHN after removing all group members

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-2
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Create a group chat.
4. Click on group chat header.
5. Go to Members.
6. Remove all the members.
7. Return to main chat.

Expected Result:

The chat header name will follow the chat name in LHN.

Actual Result:

The chat header name shows the group creator's name only, while LHN shows "User's group chat".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462517_1714114012791.bandicam_2024-04-26_14-39-01-102.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01529d302503f7e16a
• Upwork Job ID: 1785001052675362816
• Last Price Increase: 2024-04-29
• Automatic offers:
• s77rt | Reviewer | 0
• Nodebrute | Contributor | 0

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat header does not follow chat name in LHN after removing all group members

What is the root cause of that problem?

On HeaderView we use displayNamesWithTooltips for the header text where it returns the partyicipants names

App/src/pages/home/HeaderView.tsx

Line 96 in fcbc5ac

const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips(participantPersonalDetails, isMultipleParticipant, undefined, isSelfDM);

What changes do you think we should make in order to solve the problem?

We need to add a new const

const  isSingleParticipantGroupChat  =  isGroupChat  &&  participants.length  ===  1;

Then update DisplayNames

<DisplayNames
  fullTitle={title}
- displayNamesWithTooltips
+ displayNamesWithTooltips={displayNamesWithTooltips}
  tooltipEnabled={!isSingleParticipantGroupChat}
  numberOfLines={1}
  textStyles={[styles.headerText, styles.pre]}
- shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || shouldUseGroupTitle}
+ shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || shouldUseGroupTitle || isSingleParticipantGroupChat}
  renderAdditionalText={renderAdditionalText}
/>

POC:

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - Chat header does not follow chat name in LHN after removing all group members

What is the root cause of that problem?

It becomes from changes in this PR but I do not think it is regress. Here we pass shouldUseFullTitle which controls displaying fullTitle or displayNamesWithTooltips ( participant names with tooltips )

What changes do you think we should make in order to solve the problem?

Here need to understand correct behavior, should tooltip be displayed when hovering over group member name if there is only one member ?

If No - Update this condition as follows isGroupChat && (!!report?.reportName || !isMultipleParticipant);

If Yes - Add below code here

if(isGroupChat && !isMultipleParticipant){
    displayNamesWithTooltips[0].displayName = title
}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01529d302503f7e16a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)