[Awaiting Payment May 16th] [QBO] Ensure the actions to `Add` or `Delete` are not allowed on all imported coding pages

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.68-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714438462878199?thread_ts=1714400674.229349&cid=C036QM0SLJK

Action Performed:

1. Create a workspace on NewDot
2. Go to More Features > Tags > Enable (you need this step for now because otherwise Tags won't show in the LHN after you connect to QBO to see the imported coding, apparently that's going to be worked on here)
3. Enable Accounting in More Features as well
4. Go to Accounting in the workspace settings LHN
5. Connect to QBO
6. Go to Categories
7. Select a couple of category in the table
8. Click the [2 selected v] button in the page header
9. Observe the Delete categories button that shouldn't be there
10. Close the RHP modal
11. Click on a category in the table
12. Observe the three dot overflow menu in the category settings page in the RHP that shouldn't be there
13. Click the overflow menu
14. Observe the Delete category menu item that shouldn't be there.
15. Close the modal
16. Go to the Tags page
17. Observe the Add tag button in the page header that shouldn't be there
18. Repeat steps 7-14 above and observe that the admin can also delete imported tag values

Expected Result:

When coding features (Categories, Tags, Taxes) are imported from QBO, you shouldn't be able to Add or Delete the imported values. As such:

• The green Add X button should be hidden in the page header
• The Delete X menu item should be hidden in the bulk selection menu, only Disable X || Enable X should be shown.
• The overflow menu in the category setting page should be hidden as the only menu item within it is to Delete x which shouldn't be allowed

Note: Untested but likely true given the above so please check on dev, and make sure we apply the same fix to Taxes imported to the workspace as well.

Actual Result:

Admins can Add and Delete imported coding values when connected to QBO

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-04-30_01-44-14.mp4

View all open jobs on GitHub

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[trjExpensify]

CC: @aldo-expensify @hayata-suenaga @zanyrenney @narefyev91 @teneeto

[hayata-suenaga]

we need to fetch connections data on those pages. Let me create a custom hook to do that. We cannot use the existing HOC as that is going to break the offline pattern on those pages.

[trjExpensify]

we need to fetch connections data on those pages. Let me create a custom hook to do that. We cannot use the existing HOC as that is going to break the offline pattern on those pages.

Out of curiosity, how are we hiding the Add category button already when connected to QBO? 🤔

[hayata-suenaga]

Out of curiosity, how are we hiding the Add category button already when connected to QBO? 🤔

because we're already fetching the connections data with HOC. But we decided to remove this HOC as it breaks the offline pattern on Categories and Tags pages.

I'm creating the custom hook so that we don't have to block the screen when the user is offline.

anyway, I can work on this issue while waiting for that PR to be merged.

[trjExpensify]

Sounds good!