[HOLD for payment 2024-06-13] [$250] IOU – Previous Expense report title is returned, if save the title as empty

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4569904
Email or phone of affected tester (no customers): applausetester+jp_e_category_1@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create new workspace
4. Create two Submit expenses in WS chat
5. Navigate to Expense report
6. Click on title field, delete it and press Save
7. Observe the title field
8. Navigate to WS chat via header link
9. Open Expense report again
10. Observe the title field

Expected Result:

Unable to save empty Expense report title

Actual Result:

Previous Expense report title is returned, if save the title as empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489433_1716470839877.Report_title.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ce4e42d36033b48
• Upwork Job ID: 1793667673590427648
• Last Price Increase: 2024-05-23
• Automatic offers:
• cretadn22 | Contributor | 102479025

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report title doesn't throw error when we save it with empty string

What is the root cause of that problem?

For report fields, we check if the type of reportField is text and set the isRequried prop based on whether the reportField is deletable or not : !reportField.deletable as follows:

App/src/pages/EditReportFieldPage.tsx

Lines 128 to 133 in 2c9cc0a

	{(reportField.type === 'text' || isReportFieldTitle) && (
	<EditReportFieldText
	fieldName={Str.UCFirst(reportField.name)}
	fieldKey={fieldKey}
	fieldValue={fieldValue}
	isRequired={!reportField.deletable}

Now this is required prop is passed down to the EditReportFieldTextPage component:

App/src/pages/EditReportFieldText.tsx

Line 38 in 2c9cc0a

if (isRequired && values[fieldKey].trim() === '') {

This will set the error only when isRequried is set to true.

But for all the reportFields, we have deletable set to true.

Hence the assertion for isRequired={!reportField.deletable} is wrong, we should check for the fieldID.

What changes do you think we should make in order to solve the problem?

We should instead check for the reportField.fieldID prop and only set it to requried if the fieldID is text_title

So the updated code would be:

{(reportField.type === 'text' || isReportFieldTitle) && (
                <EditReportFieldText
                    fieldName={Str.UCFirst(reportField.name)}
                    fieldKey={fieldKey}
                    fieldValue={fieldValue}
                    isRequired={reportField.fieldID === CONST.REPORT_FIELD_TITLE_FIELD_ID}

Note

fieldID are unique for dropdown, date, etc fields for reportFields, The suggested solution will also not cause any regression when we have other field values as well, Also, if we create more text fields for the report, their ID's are different, so this way we make sure that we only make the input as required for the report title and all other reportFields are optional

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ce4e42d36033b48

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

expense report title allows saving empty empty title

What is the root cause of that problem?

The title field is displayed if reportField.type === 'text' or isReportFieldTitle is true. It is marked as required if reportField.deletableis false, which is incorrect.

According to this comment, the title is editable only if deletable is true, as shown here. Therefore, the title field should be required if it is not disabled. We can use !isReportFieldDisabled(report, reportField, policy) or simply change !reportField.deletable to reportField.deletable.

App/src/pages/EditReportFieldPage.tsx

Lines 128 to 135 in 2c9cc0a

	{(reportField.type === 'text' || isReportFieldTitle) && (
	<EditReportFieldText
	fieldName={Str.UCFirst(reportField.name)}
	fieldKey={fieldKey}
	fieldValue={fieldValue}
	isRequired={!reportField.deletable}
	onSubmit={handleReportFieldChange}
	/>

What changes do you think we should make in order to solve the problem?

1. change the the required field here to !isReportFieldDisabled(report, reportField, policy) or simply change the !reportField.deletable to reportField.deletable
2. OR another solution would be to make the field as always required since the EditReportFieldText page is reached only if the field is not disabled. but i would prefer to go with the first solution

Optional: we can make the same change for the date field as well

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense report title doesn't generate an error if saved with a blank string.

What is the root cause of that problem?

App/src/pages/EditReportFieldPage.tsx

Line 133 in 2c9cc0a

isRequired={!reportField.deletable}

App/src/pages/EditReportFieldPage.tsx

Line 143 in 2c9cc0a

isRequired={!reportField.deletable}

At these instances, an incorrect condition is employed, resulting in the inadvertent passing of "isRequired: false" to EditReportFieldText

What changes do you think we should make in order to solve the problem?

App/src/pages/EditReportFieldPage.tsx

Line 133 in 2c9cc0a

isRequired={!reportField.deletable}

App/src/pages/EditReportFieldPage.tsx

Line 143 in 2c9cc0a

isRequired={!reportField.deletable}

In these places, we ought to utilize isReportFieldDeletable that is defined above like this

isRequired={!isReportFieldDeletable}

What alternative solutions did you explore? (Optional)