[HOLD for payment 2024-07-26] [$250] Android - Task - Deleted task is shown briefly and then disappears from conversation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4704499
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Open a report
3. Tap plus icon -- assign task
4. Enter a title and tap next
5. Tap confirm task
6. Open the task created
7. Tap header - delete option

Expected Result:

Deleted task must not be shown briefly in conversation page

Actual Result:

Deleted task is shown briefly and then disappears from conversation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536169_1720462778895.screenrecorder-2024-07-08-20-58-12-710_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d0d653c8ad7776ae
• Upwork Job ID: 1810491099806319286
• Last Price Increase: 2024-07-09
• Automatic offers:
• alitoshmatov | Reviewer | 103061198
• dominictb | Contributor | 103061200

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

When a task is deleted, we mark the parentReportAction's pendingAction as "UPDATE"

App/src/libs/actions/Task.ts

Line 932 in 9dccffe

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

Here, if pendingAction is not "DELETE," we continue to show the deleted task until we receive the data from the backend

App/src/pages/home/report/ReportActionsList.tsx

Lines 200 to 208 in 4a3ecb3

	() =>
	sortedReportActions.filter(
	(reportAction) =>
	(isOffline ||
	ReportActionsUtils.isDeletedParentAction(reportAction) ||
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	reportAction.errors) &&
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID),
	),

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/Task.ts

Line 932 in 9dccffe

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,

Setting pendingAction to "DELETE" to indicate that a deletion action is pending

What alternative solutions did you explore? (Optional)

[VictoriaExpensify]

Issue recreated. Agree this is a bug that belongs in VSP.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d0d653c8ad7776ae

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)