[C+ Checklist Needs Completion] [$250] Profile - Address disappears when filling date of birth

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4706283
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.chat.expensify.com
2. Go to Account Setting > Profile
3. Go Address > fill the address and save
4. Go to date of birth > Fill the date and save

Expected Result:

Both Address and Date of birth are displayed in the Personal detail page

Actual Result:

The address is not shown on the personal detail page after editing Date of birth

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538125_1720630431120.Issue_Address_Disappears.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012627cfecde429dc3
• Upwork Job ID: 1811457000867073269
• Last Price Increase: 2024-07-11

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Address disappears when filling date of birth

What is the root cause of that problem?

On changing the date, the backend return the address inside an addresses array, and doesn't return the address object

What changes do you think we should make in order to solve the problem?

1. either to return merge address into onyx as well, the same as happened with the update address command
2. OR in the frontend we should check if the privatePersonalDetails.addressthen use it else check for privatePersonalDetails?.address?.[0] if found:
   for example here

we should change it to:

function getFormattedAddress(privatePersonalDetails: OnyxEntry<PrivatePersonalDetails>): string {
    const {address, addresses} = privatePersonalDetails ?? {};
    const addressToUse = (address ?? addresses?.[0]) as PrivatePersonalDetails['address'];
    const [street1, street2] = getStreetLines(addressToUse?.street);
    const formattedAddress =
        formatPiece(street1) +
        formatPiece(street2) +
        formatPiece(addressToUse?.city) +
        formatPiece(addressToUse?.state) +
        formatPiece(addressToUse?.zip) +
        formatPiece(addressToUse?.country);

    // Remove the last comma of the address
    return formattedAddress.trim().replace(/,$/, '');
}

we should update all other privatePersonalDetails.address to use privatePersonalDetails.addresses?.[0] as a fallback

alternatively

we can extract the address object from the privatePersonalDetails using:

const {addressCity,addressCountry,addressState,addressStreet,addressZip} = privatePersonalDetails

then construct the address object from these vars

Partial Result:

Screen.Recording.2024-07-10.at.10.16.19.PM.mov

alternatively

as arosiclair pointed out here we can remove the privatePersonalDetails.address completely ... to do that we should

• change the optimistic data of the change address command to use the first object of the addresses array instead of the address object
• updated all references that use privatePersonalDetails.address to use the last object of the addresses array instead

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012627cfecde429dc3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)