[$250] Address is cleared after updating legal name or date of birth

[arosiclair]

Version Number: v9.0.6-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @arosiclair
Slack conversation: N/A

Action Performed:

1. Log into NewDot
2. Avatar > Profile > Private
3. Set legal name, date of birth and address
4. Change date of birth

Expected Result:

Date of birth updates and other details are preserved

Actual Result:

Date of birth updates and the address is cleared

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-12.at.9.43.32.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c8064b2f7c784d15
• Upwork Job ID: 1811761243030749173
• Last Price Increase: 2024-07-12

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

I introduced this with performance optimizations from https://github.com/Expensify/Expensify/issues/279201.

The root problem is that NewDot is expecting the address to be saved as an address object in private_personalDetails. This does not match the format in the db where we save a history of addresses in the addresses array. The most recent address is the last object in the array.

We need to update NewDot to use addresses and remove uses of address since it does not exist in the DB. So far I saw these need to be updated:

• Optimistic data here
• getFormattedAddress

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c8064b2f7c784d15

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[Tony-MK]

@arosiclair, I believe this issue is related this #45197.

[arosiclair]

Thanks I'll add a note to it. Closing this as a dupe.