[$250] Accounting – When navigate back from NetSuite page workspace profile page opens

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in with expensifail account
2. Create Workspace> Enable Accounting
3. Go to Accounting
4. Click on connect NetSuite
5. Verify Upgrade modal appears
6. Click Back

Expected Result:

User should land on Accounting page

Actual Result:

User lands on Workspace profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553050_1721937459940.Recording__3588.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01564450f18c93f647
• Upwork Job ID: 1818424433339662150
• Last Price Increase: 2024-07-30
• Automatic offers:
• neonbhai | Contributor | 103358804

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting – When navigate back from NetSuite page workspace profile page opens

What is the root cause of that problem?

We don't define the backTo param here:

App/src/components/ConnectToNetSuiteButton/index.tsx

Line 59 in 6cf5472

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));

What changes do you think we should make in order to solve the problem?

We will add the third param pointing to policyAccountingPage. We will get it from Navigation.getActiveRouteWithoutParams()

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias, Navigation.getActiveRouteWithoutParams()));

Result

Screen.Recording.2024-07-26.at.2.08.11.AM.mov

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting – When navigate back from NetSuite page workspace profile page opens

What is the root cause of that problem?

We are not passing the backTo here

App/src/components/ConnectToNetSuiteButton/index.tsx

Lines 59 to 60 in b0f810d

	Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));
	return;

so it will fallback to the workspace profile route here

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 47 to 48 in b0f810d

	onBackButtonPress={() => Navigation.goBack(route.params.backTo ?? ROUTES.WORKSPACE_PROFILE.getRoute(policyID))}
	/>

What changes do you think we should make in order to solve the problem?

We should pass the accounting route as the backTo here

App/src/components/ConnectToNetSuiteButton/index.tsx

Lines 59 to 60 in b0f810d

	Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias));
	return;

                        Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.netsuite.alias, ROUTES.WORKSPACE_ACCOUNTING.getRoute(policyID)));

if needed we can also remove workspace profile fallback route here

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 47 to 48 in b0f810d

	onBackButtonPress={() => Navigation.goBack(route.params.backTo ?? ROUTES.WORKSPACE_PROFILE.getRoute(policyID))}
	/>

What alternative solutions did you explore? (Optional)

[melvin-bot]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01564450f18c93f647