[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Invoices - Balance is cut off when device font size is small

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #46813
Email or phone of affected tester (no customers): applausetester+kh051001@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Device font size should be small (depending on the screen size, might need to adjust font size to the smaller size).

1. Launch New Expensify app.
2. Go to workspace settings.
3. Go to Invoices.

Expected Result:

The balance will not be cut off.

Actual Result:

The balance is cut off.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6627975_1728363622395.invoice.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the device font size is small, the balance on invoices appears cut off.

What is the root cause of that problem?

The issue is due to the use of a static font size in the balance component, specifically styles.textXXXLarge:

App/src/components/Balance.tsx

Line 16 in f8e7928

return <Text style={[styles.textHeadline, styles.textXXXLarge, textStyles]}>{formattedBalance}</Text>;

App/src/styles/index.ts

Lines 451 to 453 in 672a937

	textXXXLarge: {
	fontSize: variables.fontSizeXXXLarge,
	},

App/src/styles/variables.ts

Line 65 in 5b2a329

fontSizeXXXLarge: 32,

The textHeadline style within the balance component adjusts line height based on screen scale, which in our caseresults in the line height becoming smaller than the font size, causing the text to look cut off.

App/src/styles/index.ts

Line 474 in 672a937

lineHeight: variables.lineHeightXXXLarge,

App/src/styles/variables.ts

Line 113 in 5b2a329

lineHeightXXXLarge: getValueUsingPixelRatio(32, 37),

What changes do you think we should make in order to solve the problem?

We should modify the fontSizeXXXLarge to utilize getValueUsingPixelRatio, as demonstrated here:

App/src/styles/variables.ts

Line 113 in 5b2a329

lineHeightXXXLarge: getValueUsingPixelRatio(32, 37),

Result

What alternative solutions did you explore? (Optional)

We could override the line height to remain at a constant 32 across all cases.

To implement this, we could initialize a new variable lineHeightFixedLarge:32 and override the height by placing it at the end of the style array

Result

[mjasikowski]

Checking