[Awaiting checklist] [$125] Task-Inconsistency in error display on creating task with long task title

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.46-2
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a chat
3. Enter [] long task name and send the message
4. Note there was an error creating this task, please try later message is displayed.
5. Tap plus icon -- assign task
6. Enter in title the same ling task name used in step 3
7. Tap next
8. Note character limit exceeded error is displayed

Expected Result:

There must not be inconsistency in error display for long task title while creating task using assign task & via []

Actual Result:

Inconsistency in error display for long task title while creating task using assign task & via [] .

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6628212_1728383597986.screenrecorder-2024-10-08-12-39-22-160_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844741867905614976
• Upwork Job ID: 1844741867905614976
• Last Price Increase: 2024-11-20
• Automatic offers:
• wildan-m | Contributor | 105012251

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can create a task with long title using markdown, but will result in error.

What is the root cause of that problem?

I'm guessing we don't want to allow the user to create a long title task when using markdown. The current issue is that, the regex or the logic doesn't have a limit on how much character the title should be.

App/src/pages/home/report/ReportFooter.tsx

Line 136 in 273e751

const taskRegex = `^\\[\\]\\s+(?:@(?:${emailWithOptionalDomainRegex.source}))?\\s*([\\s\\S]*)`;

In comparison, creating task from the + button has a validation to limit the task title.

App/src/pages/tasks/NewTaskDetailsPage.tsx

Lines 60 to 61 in 273e751

	} else if (values.taskTitle.length > CONST.TITLE_CHARACTER_LIMIT) {
	ErrorUtils.addErrorMessage(errors, 'taskTitle', translate('common.error.characterLimitExceedCounter', {length: values.taskTitle.length, limit: CONST.TITLE_CHARACTER_LIMIT}));

What changes do you think we should make in order to solve the problem?

We need to validate the task title length too when creating it from the markdown.

App/src/pages/home/report/ReportFooter.tsx

Lines 162 to 168 in 273e751

	} else {
	// If the mention is not valid, include it on the title.
	// The mention could be invalid if it's a short mention and failed to be converted to a full mention.
	title = `@${mentionWithDomain} ${title}`;
	}
	}
	Task.createTaskAndNavigate(report.reportID, title, '', assignee?.login ?? '', assignee?.accountID, assigneeChatReport, report.policyID, true);

if (title.length > CONST.TITLE_CHARACTER_LIMIT) {
    return false;
}

Task.createTaskAndNavigate(report.reportID, title, '', assignee?.login ?? '', assignee?.accountID, assigneeChatReport, report.policyID, true);
return true;

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task-Inconsistency in error display on creating task with long task title

What is the root cause of that problem?

When we create task from create task page, we have validation for title length so we haven't considered a display error message in case task title is too long. But we could not implement the same validation for markdown.

What changes do you think we should make in order to solve the problem?

Make changes to errors for failure data here

 errors: title.length>CONST.TITLE_CHARACTER_LIMIT ?ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('task.titleTooLong') : ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('task.genericCreateTaskFailureMessage'),

App/src/libs/actions/Task.ts

Line 269 in cb0ccbc

errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('task.genericCreateTaskFailureMessage'),

include new error in en.ts and es.ts files

        titleTooLong: 'Task title is too long',

App/src/languages/en.ts

Line 4083 in cb0ccbc

genericCreateTaskFailureMessage: 'There was an error creating this task. Please try again later.',

        taskTitleTooLong: 'El título de la tarea es demasiado largo',

App/src/languages/es.ts

Line 4128 in cb0ccbc

genericCreateTaskFailureMessage: 'Error inesperado al crear la tarea. Por favor, inténtalo más tarde.',

This task error message is what I think is most appropriate, but any error message that team agrees on could be implemented here.(BTW this is the same error message BE responds with)

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[twisterdotcom]

Very edge case, so downgrading but it is a bug.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844741867905614976