[HOLD for payment 2024-11-21] [$250] Android - Compose Box - Composer not expanded when adding emojis until reaching second line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5113856&group_by=cases:section_id&group_order=asc&group_id=306201
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the Expensify app
2. Open any chat
3. On compose box, add several emojis until reaching a second line
4. Verify the compose box is expanded and all the message is visible

Expected Result:

When the message with emojis reaches a second line, the compose box should expand to make all the message visible

Actual Result:

When adding several emojis and reaching a second line, the compose box is not expanded and only the second line is visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6642449_1729622425031.Expand.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851362613036850059
• Upwork Job ID: 1851362613036850059
• Last Price Increase: 2024-10-29
• Automatic offers:
• DylanDylann | Reviewer | 104755710
• QichenZhu | Contributor | 104755712

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851362613036850059

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Compose Box - Composer not expanded when adding emojis until reaching second line

What is the root cause of that problem?

We have set height: 0 here but currently the input height does not increase when adding emoji and reaching the second line. It is android's behavior

What changes do you think we should make in order to solve the problem?

1. Add new state in Composer component

const [inputContentHeight, setInputContentHeight] = useState<number | undefined>();

2. Update above state in onContentSizeChange

onContentSizeChange={(e) => {
    setInputContentHeight(e?.nativeEvent?.contentSize?.height)
    ....
}

3. Update composerStyle to bellow

const isAndroidNative = getPlatform() === CONST.PLATFORM.ANDROID
const composerStyle = useMemo(() => StyleSheet.flatten([
    style, textContainsOnlyEmojis ? styles.onlyEmojisTextLineHeight : {},
    isAndroidNative ? {height: inputContentHeight} : undefined
]), [style, textContainsOnlyEmojis, styles, inputContentHeight]);

What alternative solutions did you explore? (Optional)