[HOLD for payment 2024-11-13] [$250] Clicking " Please sign in again" does nothing in "Session Expired" page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @carlosmiceli
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729880182560339

Action Performed:

1. Have a " Your Session has Expired" screen
2. Click on "Please sign in again"

Expected Result:

User is taken to sign in screen

Actual Result:

Nothing happens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851043610237148822
• Upwork Job ID: 1851043610237148822
• Last Price Increase: 2024-10-28
• Automatic offers:
• aimane-chnaif | Reviewer | 104689909
• NJ-2020 | Contributor | 104689912

Issue Owner

Current Issue Owner: @CortneyOfstad

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking " Please sign in again" does nothing in "Session Expired" page

What is the root cause of that problem?

We should use goBack() function instead of navigate(), same like what we do here:

App/src/pages/LogInWithShortLivedAuthTokenPage.tsx

Lines 29 to 32 in 5103b4b

	Navigation.isNavigationReady().then(() => {
	// We must call goBack() to remove the /transition route from history
	Navigation.goBack();
	Navigation.navigate(ROUTES.HOME);

because it will remove the transition route from the history

App/src/pages/ErrorPage/SessionExpiredPage.tsx

Lines 35 to 39 in 5103b4b

	if (!NativeModules.HybridAppModule) {
	Session.clearSignInData();
	Navigation.navigate();
	return;
	}

Because if we use navigate, the transition history still persists which keeps showing the session expired page

App/src/libs/Navigation/AppNavigator/PublicScreens.tsx

Lines 24 to 33 in 5103b4b

	<RootStack.Screen
	name={NAVIGATORS.BOTTOM_TAB_NAVIGATOR}
	options={defaultScreenOptions}
	component={NativeModules.HybridAppModule ? SessionExpiredPage : SignInPage}
	/>
	<RootStack.Screen
	name={SCREENS.TRANSITION_BETWEEN_APPS}
	options={defaultScreenOptions}
	component={LogInWithShortLivedAuthTokenPage}
	/>

What changes do you think we should make in order to solve the problem?

We should use goBack instead of navigate

onPress={() => {
    if (!NativeModules.HybridAppModule) {
        Session.clearSignInData();
        Navigation.goBack();
        return;
    }
    NativeModules.HybridAppModule.closeReactNativeApp(true, false);
}}

OR

onPress={() => {
    if (!NativeModules.HybridAppModule) {
        Session.clearSignInData();
        Navigation.isNavigationReady().then(() => {
            Navigation.goBack();

            // OPTIONAL: Navigation.navigate(ROUTES.SIGN_IN_MODAL);
        });
        return;
    }
    NativeModules.HybridAppModule.closeReactNativeApp(true, false);
}}

Result

Screen.Recording.2024-10-27.at.18.29.28.mov

What alternative solutions did you explore? (Optional)

[CortneyOfstad]

I am not able to recreate, so going to see if the C+ can recreate based on the SO linked above

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851043610237148822