[$150] Profile - External user can't view the time zone(Local time) changes in the main user profile

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): testpayment935+613@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Prerequisite
Log in with Gmail account and changes time zone (Must be Gmail account)

Steps:

1. As another user (or from another device) navigate to the conversation with the main user (where all changes were made)
2. Click on the header of the conversation
3. Verify the user details page display local time of the user

Expected Result:

External user can view the time zone(Local time) changes in the main user profile. (Expensifail account behavior)

Actual Result:

External user can't view the time zone(Local time) changes in the main user profile.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6663442_1731481143451.bandicam_2024-11-13_09-57-02-653.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858726442470926380
• Upwork Job ID: 1858726442470926380
• Last Price Increase: 2025-05-09

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Nodebrute]

This behavior is expected, as we do not show the local time zone until the user has been validated. This was implemented here to address a significant privacy concern. To resolve this issue, we can remove the isParticipantValidated check from here.

App/src/pages/ProfilePage.tsx

Line 138 in 67d7299

const shouldShowLocalTime = !ReportUtils.hasAutomatedExpensifyAccountIDs([accountID]) && !isEmptyObject(timezone) && isParticipantValidated;

[twilight2294]

Edited by proposal-police: This proposal was edited at 2024-11-13 20:41:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unvalidated user cannot see his own local timezone in self-DM

What is the root cause of that problem?

Here as seen in the video, the current user should be able to see his own timezone in his own selfDM, currently we use the following check to show timezone:

App/src/pages/ProfilePage.tsx

Line 138 in 67d7299

const shouldShowLocalTime = !ReportUtils.hasAutomatedExpensifyAccountIDs([accountID]) && !isEmptyObject(timezone) && isParticipantValidated;

This case is partially correct, we only want to show timezone on profile page of any user only when the participant is validated, but for self-DM as the participant is the current user itself, we should show the timezone in case of self dm

What changes do you think we should make in order to solve the problem?

Update the check to:

    const isSelfDM = ReportUtils.isSelfDM(report)
    const shouldShowLocalTime = !ReportUtils.hasAutomatedExpensifyAccountIDs([accountID]) && !isEmptyObject(timezone) && (isParticipantValidated || isSelfDM);

What alternative solutions did you explore? (Optional)

[twilight2294]

@strepanier03 , note that the bug here is that there is no timezone displayed if the user visits his own profile from self-DM

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858726442470926380

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)