[HOLD for payment 2024-12-07] [$250] No RBR on Subscription row in the LHN in settings if the free trial has expired

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.62-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation (hyperlinked to channel name): Expensify bugs

Action Performed:

1. Open an account who free trial has expired
2. Go to settings > Subscription

Expected Result:

RBR should also be on the Subscription row in the LHN

Actual Result:

Observe that there is a RBR on the Page but not on the settings option

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858434959504168009
• Upwork Job ID: 1858434959504168009
• Last Price Increase: 2024-11-18
• Automatic offers:
• daledah | Contributor | 104948042

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No RBR on Subscription row in the LHN in settings if the free trial has expired

What is the root cause of that problem?

We are checking the condition to show RBR in the sidebar here, it depends on function hasSubscriptionRedDotError here

And with case POLICY_OWNER_WITH_AMOUNT_OWED_OVERDUE we didn't update isError=true

App/src/pages/settings/InitialSettingsPage.tsx

Line 198 in 6ba2c97

brickRoadIndicator: !!privateSubscription?.errors || SubscriptionUtils.hasSubscriptionRedDotError() ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,

App/src/libs/SubscriptionUtils.ts

Lines 356 to 358 in 6ba2c97

	function hasSubscriptionGreenDotInfo(): boolean {
	return getSubscriptionStatus()?.isError === false;
	}

What changes do you think we should make in order to solve the problem?

Simply we only need to add isError=true here

App/src/libs/SubscriptionUtils.ts

Lines 272 to 274 in 6ba2c97

	return {
	status: PAYMENT_STATUS.POLICY_OWNER_WITH_AMOUNT_OWED_OVERDUE,
	};

Noted: We should check again with another case that we need to RBR

What alternative solutions did you explore? (Optional)

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No RBR on Subscription row in the LHN in settings if the free trial has expired

What is the root cause of that problem?

On settings row, we do not check the card error for brickRoadIndicator:

App/src/pages/settings/InitialSettingsPage.tsx

Line 198 in 04d85d8

brickRoadIndicator: !!privateSubscription?.errors || SubscriptionUtils.hasSubscriptionRedDotError() ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,

This causes the bug as there will be no RBR for outdated payment methods.

What changes do you think we should make in order to solve the problem?

Like we do on the cardSection in subscription page , we should add a check for cards errors CardSectionUtils.getBillingStatus(translate, defaultCard?.accountData ?? {})?.isErrow in the settings page as well:

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 68 in 04d85d8

const [billingStatus, setBillingStatus] = useState<BillingStatusResult | undefined>(CardSectionUtils.getBillingStatus(translate, defaultCard?.accountData ?? {}));

We will get the defaultCard from fundList, same like we do in cardSection:

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 54 in 04d85d8

const defaultCard = useMemo(() => Object.values(fundList ?? {}).find((card) => card.accountData?.additionalData?.isBillingCard), [fundList]);

brickRoadIndicator: !!privateSubscription?.errors || SubscriptionUtils.hasSubscriptionRedDotError() || CardSectionUtils.getBillingStatus(translate, defaultCard?.accountData ?? {})?.isError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858434959504168009

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)