[HOLD for payment 2025-01-13] [HOLD for payment 2025-01-07] [$250] Track Expense - Website crashes when submitting a track expense.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): ibellicotest+126@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Chat Report View

Action Performed:

1. Open the staging.new.expensify.com website.
2. Open Self DM.
3. Tap on "+" button and select "Create Expense"
4. Complete the expense creation flow.

Expected Result:

After creating a track expense, the user should land on self DM again and the expense details should be visible on the chat.

Actual Result:

Website crashes after submitting a track expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702794_1735282391342!log.txt

Bug6702794_1735281424305.Track_Crash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021872615001903986307
• Upwork Job ID: 1872615001903986307
• Last Price Increase: 2024-12-27
• Automatic offers:
• brunovjk | Contributor | 105477339
• nkdengineer | Contributor | 105477345

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Website crashes after submitting a track expense.

What is the root cause of that problem?

We removed the fallback here then the app crashes when the chatReportID is changed from an empty string to an exist ID.

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 77 in e94df0f

const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`);

App/src/pages/home/report/PureReportActionItem.tsx

Line 661 in e94df0f

chatReportID={ReportActionsUtils.getOriginalMessage(action)?.IOUReportID ? report?.chatReportID ?? '' : reportID}

What changes do you think we should make in order to solve the problem?

Bring the fallback ID back

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 77 in e94df0f

const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`);

Or when we create the track expense we should set IOUReportID of the IOU action as 0 in optimistic data since BE also returns like this.

App/src/pages/home/report/PureReportActionItem.tsx

Line 661 in e94df0f

chatReportID={ReportActionsUtils.getOriginalMessage(action)?.IOUReportID ? report?.chatReportID ?? '' : reportID}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.