[Due for payment 2025-02-18] [$250] Per Diem- Per Diem Disappears from Expense Options After Changing Currency Offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.92-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): applausetester+tw4466444@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 13.6/chrome
App Component: Workspace Settings

Action Performed:

1, Go to Settings > Create Workspace.
2, Navigate to Workspace Settings > More Features > Enable Per Diem.
3,Go to Workspace Chat > Click + > Create Expense → Per Diem is available in the options.
4, Switch to Offline Mode, then go to Workspace Settings and change the currency.
5,Return to Workspace Chat > Click + > Create Expense → Per Diem is missing from the options.

Expected Result:

Per Diem should remain available in the expense details even after changing the currency offline.

Actual Result:

Per Diem disappears from the expense details when the currency is changed offline.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6728511_1738239214918.Screen_Recording_2025-01-30_at_4.11.16_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021886146687264382691
• Upwork Job ID: 1886146687264382691
• Last Price Increase: 2025-02-02
• Automatic offers:
• nkdengineer | Contributor | 105976043

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-31 01:53:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per Diem- Per Diem Disappears from Expense Options After Changing Currency Offline

What is the root cause of that problem?

We display the Per Diem option based on the following condition:

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 115 to 119 in 5f69e38

	const shouldShowPerDiemOption =
	iouType !== CONST.IOU.TYPE.SPLIT &&
	iouType !== CONST.IOU.TYPE.TRACK &&
	canUsePerDiem &&
	((!isFromGlobalCreate && doesCurrentPolicyPerDiemExist) || (isFromGlobalCreate && doesPerDiemPolicyExist));

When changing the currency while offline, doesCurrentPolicyPerDiemExist becomes false, causing the Per Diem option to disappear.
Why does this happen? When change the currency, we call the updateGeneralSettings action.
In this action, customUnits gets overridden when distanceUnit exists, leading to the policy losing the custom unit for Per Diem.

App/src/libs/actions/Policy/Policy.ts

Lines 1307 to 1312 in 5f69e38

	...(customUnitID && {
	customUnits: {
	[customUnitID]: {
	...distanceUnit,
	rates: optimisticRates,
	},

What changes do you think we should make in order to solve the problem?

We should include the custom unit's current of the policy in optimisticData, finallyData, and failureData.

App/src/libs/actions/Policy/Policy.ts

Lines 1327 to 1332 in 5f69e38

	...(customUnitID && {
	customUnits: {
	[customUnitID]: {
	...distanceUnit,
	rates: finallyRates,
	},

                ...(customUnitID && {
                    customUnits: {
                        ...policy?.customUnits, //New code
                        [customUnitID]: {
                            ...distanceUnit,
                            rates: optimisticRates,
                        },
                    },
                }),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write a test to assert that Per Diem is enabled when changing the currency.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021886146687264382691

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)