[Due for payment 2025-03-05] [$250] Copilot - User gets stucked in Copilot account when removed by the other user

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.93-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5546706&group_by=cases:section_id&group_order=asc&group_id=229064
Email or phone of affected tester (no customers): ibellicotest+229@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: User Settings

Action Performed:

1. Open the Expensify app.
2. Log in with an account that was assigned as Copilot.
3. Tap on "Settings"
4. Tap on the copilot switcher on top of the screen and switch to the copilot account.
5. In another device or environment, open the main account and removed the first account as copilot.
6. Switch to first account again and check if the copilot account was removed and the account can be normally used.
7. If copilot wasn´t removed, try to switch accounts again to return to the main one.
8. Check the app´s behavior with this action.

Expected Result:

When user is removed as copilot, the app should be automatically updated and returned to the main account.

Actual Result:

User can´t return to main account when removed as copilot after switching account. When selecting main account on switcher, a "Something went wrong" message is displayed and the user gets stuck in copilot account. Killing and relaunching the app, leads to infinite loading in settings section and the only way to be able to use the account normally again, is by logging out and re logging in.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885343462254488429
• Upwork Job ID: 1885343462254488429
• Last Price Increase: 2025-02-07
• Automatic offers:
• ijmalik | Contributor | 106130462

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885343462254488429

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[ijmalik]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-02 05:41:28 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copilot - User remains stuck in the Copilot account after being removed by another user.

What is the root cause of that problem?

1.1- Onyx State Before Copilot removal: complete state

{
    "delegates": [
        {"email": "aeyufykqpruf+bvz@qxnis.com", "role": "all"},
        {"email": "xfokaxqrmxii+zyt@ppdyv.com", "role": "all"}
    ],
    "delegators": [],
    "delegate": "xfokaxqrmxii+zyt@ppdyv.com"
}

The delegate email xfokaxqrmxii+zyt@ppdyv.com is present in the delegatesarray.

1.2- When another user removes the copilot

Pusher event at client side:

{
    "updates": [
        {
            "data": [
                {
                    "key": "account",
                    "onyxMethod": "merge",
                    "value": {
                        "delegatedAccess": {
                            "delegates": [{"email": "expensifyijm+302@gmail.com", "role": "all"}],
                            "delegators": []
                        }
                    }
                }
            ],
            "eventType": "onyxApiUpdate"
        }
    ],
    "lastUpdateID": 4106093418,
    "previousUpdateID": 4106079691
}

Onyx State After Copilot removal by pusher: complete state

{
    "delegates": [{"email": "sejtiffadtzi+zxm@lyilw.com", "role": "all"}],
    "delegators": [],
    "delegate": "nnenlvagqzft+txi@ogmlq.com"
}

delegate email nnenlvagqzft+txi@ogmlq.com is not present in delegates array. it has been removed by the pusher.

So pusher is properly updating Onyx.

2. Why Users Get Stuck?

App/src/libs/actions/Delegate.ts

Lines 148 to 160 in a8daefb

	const restrictedToken = response.restrictedToken;
	const policyID = activePolicyID;
	return SequentialQueue.waitForIdle()
	.then(() => Onyx.clear(KEYS_TO_PRESERVE_DELEGATE_ACCESS))
	.then(() => {
	// Update authToken in Onyx and in our local variables so that API requests will use the new authToken
	updateSessionAuthTokens(response?.restrictedToken, response?.encryptedAuthToken);
	NetworkStore.setAuthToken(response?.restrictedToken ?? null);
	confirmReadyToOpenApp();
	openApp().then(() => NativeModules.HybridAppModule?.switchAccount(email, restrictedToken, policyID, String(previousAccountID)));
	});

When connected as copilot expensifyijm+298@gmail.com, all server communication is tied to this account.
After removal, the session remains active but API calls fail with the following response:

{
    "jsonCode": 408,
    "title": "Session expired",
    "message": "The account you are trying to use is deleted.",
    "requestID": "90af0866deabeaeb-KHI"
}

This results in the user being stuck.

What changes do you think we should make in order to solve the problem?

Remove following

App/src/libs/actions/Delegate.ts

Lines 31 to 34 in a8daefb

	Onyx.connect({
	key: ONYXKEYS.CREDENTIALS,
	callback: (value) => (credentials = value ?? {}),
	});

And add following code at

App/src/libs/actions/Delegate.ts

Line 61 in a8daefb

Onyx.connect({
    key: ONYXKEYS.ACCOUNT,
    callback: (val) => {
        delegatedAccess = val?.delegatedAccess ?? {};

        if (!delegatedAccess || Object.keys(delegatedAccess).length === 0 || !stashedSession || Object.keys(stashedSession).length === 0) {
            return;
        }
        
        const {delegates = [], delegate} = delegatedAccess;
        
        if (delegates.length && !delegates.some(d => d.email === delegate)) {
            restoreDelegateSession(stashedSession);
        }
    },
});

Note: This is pseudo-code and will be refined in the PR.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Handling invalid responses by restoring the delegate session when authentication tokens are missing.

App/src/libs/actions/Delegate.ts

Lines 209 to 217 in a8daefb

	if (!response?.authToken || !response?.encryptedAuthToken) {
	Log.alert('[Delegate] No auth token returned while disconnecting as a delegate');
	return;
	}
	if (!response?.requesterID || !response?.requesterEmail) {
	Log.alert('[Delegate] No requester data returned while disconnecting as a delegate');
	return;
	}

with

if (!response?.authToken || !response?.encryptedAuthToken || !response?.requesterID || !response?.requesterEmail) {
    restoreDelegateSession(stashedSession);
    return;
}

Please refer to this detailed video for a clearer understanding
Video

[ijmalik]

Proposal

Updated

[github-actions]

⚠️ @ijmalik Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).