[Due for payment 2025-03-31] [Due for payment 2025-03-21] [Due for payment 2025-03-17] [$250] Ensure Message Previews Always Include Sender Name, Even for Own Messages in Admin Room

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.0.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify bugs

Action Performed:

1. Navigate to admin room of a workspace
2. Send a message
3. Observe the LHN

Expected Result:

Sender's name included in preview(LHN) even for own message

Actual Result:

Sender's name not included in preview for own messages sent in admin room.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891959601375034888
• Upwork Job ID: 1891959601375034888
• Last Price Increase: 2025-02-18
• Automatic offers:
• nkdengineer | Contributor | 106262469

Issue Owner

Current Issue Owner: @allroundexperts / @isabelastisser

Issue Owner

Current Issue Owner: @garrettmknight / @isabelastisser

Issue Owner

Current Issue Owner: @garrettmknight / @isabelastisser

[melvin-bot]

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A feature request to show the sender name even for our own message in the admins room.

What is the root cause of that problem?

We currently only show the sender name if there are multiple participants and the sender is a different user.

App/src/libs/OptionsListUtils.ts

Lines 535 to 540 in e66ec9a

	function getLastActorDisplayName(lastActorDetails: Partial<PersonalDetails> | null, hasMultipleParticipants: boolean) {
	return hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID !== currentUserAccountID
	? // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	lastActorDetails.firstName || formatPhoneNumber(getDisplayNameOrDefault(lastActorDetails))
	: '';
	}

What changes do you think we should make in order to solve the problem?

We can update getLastActorDisplayName to accept a new param that allows same user.

return hasMultipleParticipants && lastActorDetails && (showForAllUser || lastActorDetails.accountID !== currentUserAccountID)
    ? // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
        lastActorDetails.firstName || formatPhoneNumber(getDisplayNameOrDefault(lastActorDetails))
    : '';

This will show the sender name even if it's our own message, but still only if there are multiple participants. If we want the sender name to always shown even with a single participant, then we can update it to:

return lastActorDetails && ((hasMultipleParticipants && lastActorDetails.accountID !== currentUserAccountID) || alwaysShow)

The sender name will also show for update message. If we don't want that, then we can check if it's an ADDCOMMENT action or not.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test getLastActorDisplayName to make sure it returns the correct display name based on the new param.