[Due for payment 2025-04-10] [$125] Refactor completeOnboarding to use a parameter object

[neil-marcellini]

As part of the tracking issue, and as advised in its description, refactor completeOnboarding to use a parameter object.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021893020274645384489
• Upwork Job ID: 1893020274645384489
• Last Price Increase: 2025-02-21
• Automatic offers:
• Krishna2323 | Contributor | 106500007

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021893020274645384489

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Refactor completeOnboarding to use a parameter object

What is the root cause of that problem?

• Refactor

What changes do you think we should make in order to solve the problem?

• Add parameter object for completeOnboarding in App.ts

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[gurus00]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Refactor completeOnboarding

What is the root cause of that problem?

Refactoring

What changes do you think we should make in order to solve the problem?

refactor completeOnboarding to use a parameter object.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @gurus00! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>