[Due for payment 2025-04-03] [$250] Group - Closed keyboard opens again after adding a user to a group

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @alexpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Tap on FAB
2. Tap on "Start chat"
3. Tap on the search input so the keyboard is opened
4. Select a any user tapping on "Add to group"
5. Verify the keyboard is not closed or reopened after selecting an user
6. Close the keyboard by defocusing the input
7. Select a member by tapping "Add to group"

Expected Result:

Keyboard is NOT opened again

Actual Result:

Keyboard opens again

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Keyboard.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902286850403570448
• Upwork Job ID: 1902286850403570448
• Last Price Increase: 2025-03-19

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-04 15:13:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard opens again

What is the root cause of that problem?

After selecting user, we focus input again

App/src/pages/NewChatPage.tsx

Line 217 in c406bee

selectionListRef.current?.focusTextInput();

What changes do you think we should make in order to solve the problem?

We should remove this line

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We have a test file here. Add new test to verify that input is not focus after select user
https://github.com/Expensify/App/blob/main/tests/ui/NewChatPageTest.tsx

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ryntgh]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-04 15:22:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group - Closed keyboard opens again after adding a user to a group

What is the root cause of that problem?

toggleOption function triggers a call to selectionListRef.current?.focusTextInput(), which forces the text input to gain focus and opens the keyboard.

What changes do you think we should make in order to solve the problem?

We can disable the call to focusTextInput() within the toggleOption function when the action is triggered by clicking "addToGroup."

const toggleOption = useCallback(
    (option: ListItem & Partial<OptionData>, fromButton = false) => {
        const isOptionInList = !!option.isSelected;

        let newSelectedOptions;

        if (isOptionInList) {
            newSelectedOptions = reject(selectedOptions, (selectedOption) => selectedOption.login === option.login);
        } else {
            newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? `${CONST.DEFAULT_NUMBER_ID}`}];
            selectionListRef?.current?.scrollToIndex(0, true);
        }

        // Only clear input and focus if not triggered from the addToGroup button
        if (!fromButton) {
            selectionListRef?.current?.clearInputAfterSelect?.();
            selectionListRef.current?.focusTextInput();
        }
        setSelectedOptions(newSelectedOptions);
    },
    [selectedOptions, setSelectedOptions],
);

<Button
    onPress={() => toggleOption(item, true)}
    style={[styles.pl2]}
    text={translate('newChatPage.addToGroup')}
    innerStyles={buttonInnerStyles}
    small
/>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Make a test to verify that clicking the "addToGroup" button does not open the keyboard

What alternative solutions did you explore? (Optional)

None

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[bernhardoj]

Coming from #29003 (comment)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The keyboard shows again every time we add a user to the group selection.

What is the root cause of that problem?

This happens after #54994 where we always refocus the text input after adding a user to the group selection.

App/src/pages/NewChatPage.tsx

Lines 217 to 220 in c5bba74

	selectionListRef.current?.focusTextInput();
	setSelectedOptions(newSelectedOptions);
	},
	[selectedOptions, setSelectedOptions],

This was previously fixed in #33584 by not refocusing on touchscreen devices but this isn't working anymore since we are rendering a custom right component.

App/src/pages/NewChatPage.tsx

Line 362 in c5bba74

shouldPreventDefaultFocusOnSelectRow={!canUseTouchScreen()}

What changes do you think we should make in order to solve the problem?

We need to apply the same fix back to the custom right component.

if (!canUseTouchScreen()) {
    selectionListRef.current?.focusTextInput();
}

Or we can use if (canFocusInputOnScreenFocus()).

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can create a test and mock the canUseTouchScreen return value and assert that the input isn't focused when canUseTouchScreen is true, and vice versa, when adding a user to the group selection.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Opened up for proposal review.