[Due for payment 2025-04-14] [$250] iOS - Rules - Prohibited expenses - Offline indicator is not at the page bottom

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+200302kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Rules feature is enabled.

1. Launch ND or hybrid app.
2. Go to workspace settings > Rules.
3. Go to Prohibited expenses.
4. Go offline.

Expected Result:

Offline indicator will be at the page bottom.

Actual Result:

Offline indicator is below the content.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6778631_1742599253368.ScreenRecording_03-22-2025_07-16-58_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904049457294436538
• Upwork Job ID: 1904049457294436538
• Last Price Increase: 2025-03-24
• Automatic offers:
• linhvovan29546 | Contributor | 106747818

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is below the content.

What is the root cause of that problem?

We don't style RulesProhibitedDefaultPage component correctly

App/src/pages/workspace/rules/RulesProhibitedDefaultPage.tsx

Lines 49 to 121 in 8deddfa

	<Text style={[styles.flexRow, styles.alignItemsCenter, styles.mt3, styles.mh5, styles.mb5]}>
	<Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.rules.individualExpenseRules.prohibitedDefaultDescription')}</Text>
	</Text>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.mt3, styles.mh5, styles.mb5]}>
	<Text>{translate('workspace.rules.individualExpenseRules.adultEntertainment')}</Text>
	<Switch
	isOn={policy?.prohibitedExpenses?.adultEntertainment ?? false}
	accessibilityLabel={translate('workspace.rules.individualExpenseRules.adultEntertainment')}
	onToggle={() => {
	const prohibitedExpenses: ProhibitedExpenses = {
	...policy?.prohibitedExpenses,
	adultEntertainment: !policy?.prohibitedExpenses?.adultEntertainment,
	};
	setPolicyProhibitedExpenses(policyID, prohibitedExpenses);
	}}
	/>
	</View>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.mt3, styles.mh5, styles.mb5]}>
	<Text>{translate('workspace.rules.individualExpenseRules.alcohol')}</Text>
	<Switch
	isOn={policy?.prohibitedExpenses?.alcohol ?? false}
	accessibilityLabel={translate('workspace.rules.individualExpenseRules.alcohol')}
	onToggle={() => {
	const prohibitedExpenses: ProhibitedExpenses = {
	...policy?.prohibitedExpenses,
	alcohol: !policy?.prohibitedExpenses?.alcohol,
	};
	setPolicyProhibitedExpenses(policyID, prohibitedExpenses);
	}}
	/>
	</View>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.mt3, styles.mh5, styles.mb5]}>
	<Text>{translate('workspace.rules.individualExpenseRules.gambling')}</Text>
	<Switch
	isOn={policy?.prohibitedExpenses?.gambling ?? false}
	accessibilityLabel={translate('workspace.rules.individualExpenseRules.gambling')}
	onToggle={() => {
	const prohibitedExpenses: ProhibitedExpenses = {
	...policy?.prohibitedExpenses,
	gambling: !policy?.prohibitedExpenses?.gambling,
	};
	setPolicyProhibitedExpenses(policyID, prohibitedExpenses);
	}}
	/>
	</View>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.mt3, styles.mh5, styles.mb5]}>
	<Text>{translate('workspace.rules.individualExpenseRules.hotelIncidentals')}</Text>
	<Switch
	isOn={policy?.prohibitedExpenses?.hotelIncidentals ?? false}
	accessibilityLabel={translate('workspace.rules.individualExpenseRules.hotelIncidentals')}
	onToggle={() => {
	const prohibitedExpenses: ProhibitedExpenses = {
	...policy?.prohibitedExpenses,
	hotelIncidentals: !policy?.prohibitedExpenses?.hotelIncidentals,
	};
	setPolicyProhibitedExpenses(policyID, prohibitedExpenses);
	}}
	/>
	</View>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween, styles.mt3, styles.mh5, styles.mb5]}>
	<Text>{translate('workspace.rules.individualExpenseRules.tobacco')}</Text>
	<Switch
	isOn={policy?.prohibitedExpenses?.tobacco ?? false}
	accessibilityLabel={translate('workspace.rules.individualExpenseRules.tobacco')}
	onToggle={() => {
	const prohibitedExpenses: ProhibitedExpenses = {
	...policy?.prohibitedExpenses,
	tobacco: !policy?.prohibitedExpenses?.tobacco,
	};
	setPolicyProhibitedExpenses(policyID, prohibitedExpenses);
	}}
	/>
	</View>

What changes do you think we should make in order to solve the problem?

We should wrap this component in a View with style.flex1 like we did

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersInPage.tsx

Line 38 in 8deddfa

<View style={[styles.flex1]}>

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx

Line 34 in 8deddfa

<View style={[styles.flex1]}>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.