[Due for payment 2025-04-16] [$250] Track expense - LHN preview shows "Expensify: tracking x" after dismissing actionable whisper

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): mdfoiddfoid@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

• Account has self DM.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense.
4. Click Do nothing.

Expected Result:

LHN preview will show "You: tracking x" after dismissing actionable whisper.

Actual Result:

LHN preview shows "Expensify: tracking x" after dismissing actionable whisper.
It only shows "You: tracking x" after reopening the chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904639203158747322
• Upwork Job ID: 1904639203158747322
• Last Price Increase: 2025-03-25

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @flaviadefaria

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - LHN preview shows "Expensify: tracking x" after dismissing actionable whisper

What is the root cause of that problem?

We are getting the lastActorAccountID from report but when we press nothing report.lastActorAccountID not update and lastActorDetails remain same

App/src/libs/SidebarUtils.ts

Line 507 in 8deddfa

let lastActorDetails: Partial<PersonalDetails> | null = report.lastActorAccountID && personalDetails?.[report.lastActorAccountID] ? personalDetails[report.lastActorAccountID] : null;

Then we call getLastActorDisplayName with same lastActorDetails

App/src/libs/SidebarUtils.ts

Line 519 in 8deddfa

const lastActorDisplayName = getLastActorDisplayName(lastActorDetails);

lastActorDetails.accountID was same as previous that make bellow condition remain true

App/src/libs/OptionsListUtils.ts

Line 541 in 8deddfa

return lastActorDetails.accountID !== currentUserAccountID

What changes do you think we should make in order to solve the problem?

We should get the lastActorAccountID from lastAction

    const lastActorAccountID = lastAction?.actorAccountID ?? report.lastActorAccountID;

and update this logic like this

let lastActorDetails: Partial<PersonalDetails> | null = lastActorAccountID && personalDetails?.[lastActorAccountID] ? personalDetails[lastActorAccountID] : null;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

RESULTS

Screen.Recording.2025-03-22.at.1.18.00.PM.mov