[Due for payment 2025-04-03] [$250] Reports - Select option is shown for messages in Chats

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.19-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kok1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

1. Launch ND or hybrid app.
2. Go to Reports.
3. Tap bookmark icon.
4. Tap Chats.
5. Long tap on any message.
6. Tap Select.

Expected Result:

In Step 5, no menu will open when long tapping on the message (production behavior).

Actual Result:

In Step 5, Select menu opens when long tapping on the message.
In Step 6, after tapping Select, nothing is selected.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6782488_1742976295928.ScreenRecording_03-26-2025_16-02-34_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904885697168632418
• Upwork Job ID: 1904885697168632418
• Last Price Increase: 2025-03-26
• Automatic offers:
• daledah | Contributor | 106675793
• ikevin127 | Contributor | 106675802

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 5, Select menu opens when long tapping on the message.
In Step 6, after tapping Select, nothing is selected.

What is the root cause of that problem?

This comes from #57549

We pass onLongPressRow without checking if data is of chat type

App/src/components/Search/SearchList.tsx

Line 281 in 83994af

onLongPressRow={handleLongPressRow}

What changes do you think we should make in order to solve the problem?

We can add a flag shouldPreventLongPressRow, defaults to false

handleLongPressRow will return early if shouldPreventLongPressRow is true

App/src/components/SelectionListWithModal/index.tsx

Lines 80 to 84 in 83994af

	const handleLongPressRow = (item: TItem) => {
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || (!isFocused && !isScreenFocused)) {
	return;
	}

    const handleLongPressRow = useCallback(
        (item: SearchListItem) => {
            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
            if (shouldPreventLongPressRow || !isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || !isFocused) {
                return;
            }

Then pass it here as true if it's chat type

App/src/components/Search/index.tsx

Line 449 in 83994af

<SearchList

shouldPreventLongPressRow={isChat}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.