[$250] Context menu slides in from edge of window

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @QichenZhu
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Open New Expensify website or desktop app.
2. Open any non-empty chat (send a message if none exist).
3. Press Command + R to refresh the page.
4. Move the mouse over any message and near the right border of the window, then right-click.

Expected Result:

The context menu slides in from the edge of the window.

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

context-menu-slides-in.mov

Recording.1090.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907002144603384200
• Upwork Job ID: 1907002144603384200
• Last Price Increase: 2025-04-01

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[QichenZhu]

Please consider updating the issue description based on this comment:

Expected Result: The context menu should appear without sliding in.
Actual Result: The context menu slides in from the edge of the window.

[andriivitiv]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-28 19:05:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Context menu slides in from edge of window

What is the root cause of that problem?

When the popover is rendered for the first time, we make it invisible until its dimensions are measured

App/src/components/PopoverWithMeasuredContent.tsx

Lines 168 to 173 in 770363a

	<View
	style={styles.invisiblePopover}
	onLayout={measurePopover}
	>
	{children}
	</View>

The measurePopover callback is then invoked, storing the width and height in the state while also setting isContentMeasured to true

App/src/components/PopoverWithMeasuredContent.tsx

Lines 82 to 86 in 770363a

	const measurePopover = ({nativeEvent}: LayoutChangeEvent) => {
	setPopoverWidth(nativeEvent.layout.width);
	setPopoverHeight(nativeEvent.layout.height);
	setIsContentMeasured(true);
	};

These measured dimensions are later used to determine the popover’s position on the screen

App/src/components/PopoverWithMeasuredContent.tsx

Lines 125 to 126 in 770363a

	const horizontalShift = PopoverWithMeasuredContentUtils.computeHorizontalShift(adjustedAnchorPosition.left, popoverWidth, windowWidth);
	const verticalShift = PopoverWithMeasuredContentUtils.computeVerticalShift(

The issue occurs when the measurePopover callback is called with 0 width and 0 height values. This happens when the children component renders nothing (for example, returning undefined).

To calculate the horizontal position, the popover's width is subtracted from the screen width. However, since the popover's width is 0, it appears offscreen.

When the children eventually render and the dimensions are recalculated, the popover moves into the correct position, which looks like a slide-in animation.

What changes do you think we should make in order to solve the problem?

Change this line

App/src/components/PopoverWithMeasuredContent.tsx

Line 85 in 770363a

setIsContentMeasured(true);

to

setIsContentMeasured(nativeEvent.layout.width > 0 && nativeEvent.layout.height > 0);

This will ensure that the popover only appears when the content is rendered and the position on the screen can be calculated correctly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, UI bug.

[melvin-bot]

@laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021907002144603384200

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)