[Due for payment 2025-06-12] [Due for payment 2025-04-25] [$250] Receipt empty state missing from one-expense report view

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.20-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #expensify-bug

Action Performed:

1. Create a workspace
2. Submit an expense
3. Approve and pay the report
4. Click on the expense

Expected Result:

Empty state receipt placeplace holder appears

Actual Result:

Empty state receipt does not appear

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907101717917425300
• Upwork Job ID: 1907101717917425300
• Last Price Increase: 2025-04-08
• Automatic offers:
• FitseTLT | Contributor | 106856680

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Receipt empty state missing from one-expense report view

What is the root cause of that problem?

We don't show the receipt when it's paid or approved

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 407 to 409 in 8e92538

	const isReceiptAllowed = !isPaidReport && !isInvoice;
	const shouldShowReceiptEmptyState =
	isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover || isRequestor) && (canEditReceipt || isPaidGroupPolicy(report));

What changes do you think we should make in order to solve the problem?

1. We should update these condition to allow show the receipt

     const isReceiptAllowed = !isInvoice;
    const shouldShowReceiptEmptyState =
        isReceiptAllowed && !hasReceipt && (canEditReceipt || isAdmin || isApprover || isRequestor) && (canEditReceipt || isPaidGroupPolicy(report));

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 407 to 409 in 8e92538

	const isReceiptAllowed = !isPaidReport && !isInvoice;
	const shouldShowReceiptEmptyState =
	isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover || isRequestor) && (canEditReceipt || isPaidGroupPolicy(report));

2. OPTIONAL: We can create a new parameter to remove the plus button in receipt empty state and pass this as isThumbnail props here

    const shouldShowReceiptAsThumnail = isApproved || isSettled || isPaidReport;
    ...
    isThumbnail={shouldShowReceiptAsThumnail}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

This is not a bug.

[lydiabarclay]

@FitseTLT can you give some more context please?

[FitseTLT]

receipt empty placeholder is used for adding a receipt and in this case we can't add a receipt as it is approved and paid report.

[lydiabarclay]

@shawnborton can you confirm that this is expected behavior and can be closed?

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Receipt empty state missing from one-expense report view

What is the root cause of that problem?

We hide the receipt when it is paid:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 407 to 409 in 8e92538

	const isReceiptAllowed = !isPaidReport && !isInvoice;
	const shouldShowReceiptEmptyState =
	isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover || isRequestor) && (canEditReceipt || isPaidGroupPolicy(report));

So we don't see one.

What changes do you think we should make in order to solve the problem?

Based on the latest slack discussion on Expensify-bugs, we need to show the receipt and just hide the + icon.

So the solution here is:

const isReceiptAllowed = !isInvoice;

And then here, hide the plus button if the expense is paid approved or settled:

 const shouldShowReceiptAsThumnail = isApproved || isSettled || isPaidReport;
...
<ReceiptEmptyState
           hasError={hasErrors}
          isThumbnail={shouldShowReceiptAsThumnail}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write a UI test to mock the expense page and have set the expense as paid then verify that we are seeing the ReceiptEmptyState with the thumbnail not visible.

What alternative solutions did you explore? (Optional)

N/A

[lydiabarclay]

bumped design in Slack to confirm whether this is expected behavior and can be closed

[dannymcclain]

receipt empty placeholder is used for adding a receipt and in this case we can't add a receipt as it is approved and paid report.

This is true—we had an internal discussion about this and want to update the behavior so that the empty state is still shown (but without the green plus button). This is more in line with how we handle other fields when they become non-editable (i.e. Merchant, Date, etc). We still show them, you just can't edit them anymore.

Here's a mock of the expected outcome for the receipt thumbnail/placeholder area:

cc @Expensify/design for viz.

[shawnborton]

Yup, totally agree with what Danny has above - that is the expected behavior.