[Due for payment 2025-04-25] [$250] Workspace - "Select multiple" in Members and Categories page has different style

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.22-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Workspace Settings

Action Performed:

1. Launch the app.
2. Go to workspace settings > Members.
3. Invite another member if there is no other member.
4. Long tap on the member > Select.
5. Go to workspace settings > Categories.
6. Long tap on any category > Select.

Expected Result:

"Select multiple" in Members and Categories page will have the same style.

Actual Result:

"Select multiple" in Members and Categories page has different style.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907506240427805442
• Upwork Job ID: 1907506240427805442
• Last Price Increase: 2025-04-02

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "Select multiple" in Members and Categories page has different style

What is the root cause of that problem?

We don't add props shouldUseHeadlineHeader if selectionModeHeader for the header back button in category page

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 413 in 9e6f6e2

shouldUseHeadlineHeader={!selectionModeHeader}

And always set it as true in WorkspacePageWithSections

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 189 in 9e6f6e2

shouldUseHeadlineHeader

What changes do you think we should make in order to solve the problem?

We should add this shouldUseHeadlineHeader as true in WorkspaceCategoriesPage

Or update headerWithBackButton in WorkspacePageWithSections component when selectionModeHeader is true by

1. Create a new prop shouldUseHeadlineHeader in WorkspacePageWithSections component

2. Pass this as !selectionModeHeader in

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 665 to 685 in 9e6f6e2

	<WorkspacePageWithSections
	headerText={selectionModeHeader ? translate('common.selectMultiple') : translate('workspace.common.members')}
	route={route}
	icon={!selectionModeHeader ? ReceiptWrangler : undefined}
	headerContent={!shouldUseNarrowLayout && getHeaderButtons()}
	testID={WorkspaceMembersPage.displayName}
	shouldShowLoading={false}
	shouldShowOfflineIndicatorInWideScreen
	shouldShowThreeDotsButton={isPolicyAdmin}
	threeDotsMenuItems={threeDotsMenuItems}
	threeDotsAnchorPosition={threeDotsAnchorPosition}
	shouldShowNonAdmin
	onBackButtonPress={() => {
	if (selectionMode?.isEnabled) {
	setSelectedEmployees([]);
	turnOffMobileSelectionMode();
	return;
	}
	Navigation.goBack();
	}}
	>

Note: We can check other pages like tag, tax,... and do the same.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[NicMendonca]

@Expensify/design fyi!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021907506240427805442

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[dannymcclain]

😮

The categories example is the correct one 👍

[dubielzyk-expensify]

So weird how these bugs happen, but good we caught it. What Danny said looks right

[shawnborton]

Agree, and agree!