[Due for payment 2025-04-25] [$250] Expense - When an expense is deleted offline, only the email of the submitter is shown

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.22-10
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+tw313414111@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 13.6/Chrome
App Component: Money Requests

Action Performed:

Pre condition: Sign in with an Expensifail account

1. Go to Workspace Chat > Click the Plus (+) Sign > Select Manually.
2. Enter Amount, add Merchant, and Submit.
3. Switch to Offline Mode > Delete the expense.
4. Notice that only the email of the expense submitter is displayed.

Expected Result:

The expense should either be fully removed or indicate which line item was erased.

Actual Result:

When the expense is deleted offline, only the submitter’s email is displayed at the end.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6791432_1743702192261.Screen_Recording_2025-04-03_at_10.33.15_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909739315985444002
• Upwork Job ID: 1909739315985444002
• Last Price Increase: 2025-04-08
• Automatic offers:
• allgandalf | Reviewer | 106864301
• daledah | Contributor | 106864302

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - When an expense is deleted offline, only the email of the submitter is shown

What is the root cause of that problem?

We don't cover case deleted expense in MoneyRequestReportPreview component

App/src/pages/home/report/PureReportActionItem.tsx

Lines 778 to 793 in 267c75e

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && canUseTableReportView) {
	children = (
	<MoneyRequestReportPreview
	// eslint-disable-next-line @typescript-eslint/non-nullable-type-assertion-style
	iouReportID={getIOUReportIDFromReportActionPreview(action) as string}
	policyID={report?.policyID}
	chatReportID={reportID}
	action={action}
	contextMenuAnchor={popoverAnchorRef.current}
	isHovered={hovered}
	isWhisper={isWhisper}
	checkIfContextMenuActive={toggleContextMenuFromActiveReportAction}
	onPaymentOptionsShow={() => setIsPaymentMethodPopoverActive(true)}
	onPaymentOptionsHide={() => setIsPaymentMethodPopoverActive(false)}
	/>
	);

What changes do you think we should make in order to solve the problem?

We should show the ReportPreview component in case deleted expense by updating this condition

   if (action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && canUseTableReportView && action.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - When an expense is deleted offline, only the email of the submitter is shown

What is the root cause of that problem?

We show pending delete report actions while offline

App/src/pages/home/report/ReportActionsView.tsx

Lines 195 to 197 in 267c75e

	(reportAction) =>
	(isOffline || isDeletedParentAction(reportAction) || reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || reportAction.errors) &&
	shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canPerformWriteAction),

but after deleting the transaction list is empty so we don't display anything

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 441 in 267c75e

transactions.length > 0 && (

What changes do you think we should make in order to solve the problem?

For canUseTableReportView we should hide pending delete report previews

App/src/pages/home/report/ReportActionsView.tsx

Lines 195 to 197 in 267c75e

	(reportAction) =>
	(isOffline || isDeletedParentAction(reportAction) || reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || reportAction.errors) &&
	shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canPerformWriteAction),

                    ((isOffline && !(canUseTableReportView && reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW)) ||

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

n / a

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909739315985444002

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)