[Due for payment 2025-05-30] [CRITICAL] Investigate performance issues when deleting expenses from Reports page

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C05LX9D6E07/p1743598259881369

Action Performed:

Break down in numbered steps

1. Using very heavy account similar to Jason's
2. Go to the Reports page
3. Delete some expense

Expected Result:

Describe what you think should've happened

The app should not show signs of slowing down

Actual Result:

Describe what actually happened

The app grinds to halt

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

@TMisiukiewicz I see you are starred on this GH - are you investigating this? I'm adding an Internal label - I assume this needs to be internal but let me know if I can open this up to External

[mountiny]

Yeah he is on it

[TMisiukiewicz]

While using heavy account I noticed we already have a lot of heavy operations going on when opening a report so the CPU might be hit even before going to report details and pressing Delete. It's because SearchAutocompleteList is rendered all the time (just hidden behind display: none) and it recomputes entire options list in the context on each report collection item update even if it's hidden and not related to action user is doing. When we open an expense from a list, it updates a couple of reports and that triggers the computations. While it works fine on smaller accounts, it gets pretty complex for bigger ones. Actually once Search is visited, the options are regenerated from scratch on each merge to reports collection so CPU gets hit pretty often.

I tried building a PoC with exposing sourceValue to useOnyx with collection items and it seems when used in the OptionListContextProvider, it reduces this overhead to the minimum. I'll do some cleanup on Monday and open PRs in Onyx and E/App repos so you can verify it.

I haven't tested it yet but I'm wondering if this solution going to work properly with deleted items as well 🤔 Are deleted reports entirely removed from Onyx or they have any specific status set that indicates those expenses are deleted? I'm wondering if I am able to catch those by sourceValue or not, because if they are not changed through mergeCollection while being deleted, I have to think additional approach to remove the options for such reports without recomputing everything

[TMisiukiewicz]

Created draft PR for onyx with exposing sourceValue for useOnyx hook: Expensify/react-native-onyx#627

I'm working on proper implementing it to OptionListContextProvider, I think the only thing that left is that the same report now appears for me twice in the options list. Once it's fixed, it'll reduce some heavy computations on large accounts, from my initial measurements on our heavy account on web, depending on an action user is performing, it's 500-1000ms less calculations whenever doing something on Search screen, e.g. opening an expense, updating its description/merchant etc. It'll also reduce computations on any action that is doing changes on reports collection, like sending/receiving a message.

Yet I haven't tested it with deleting an expenses, but I think it should be doable as well.