[$250] LHN - "Trial" sign, is displayed on #Admins room of WS when adding work Email on onboarding

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+583@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Open the staging.new.expensify.com website.
2. Sign up with a new account.
3. On the first onboarding step, add a work Email like XXX@working.com
4. Tap on "Add work Email" button.
5. Complete the rest of onboarding steps.
6. Once redirected to inbox, tap on FAB and select "New Workspace"
7. Complete the workspace creation flow.
8. Return to inbox.
9. Note that now, on #Admins room of the created workspace, a "Trial: 30 days left" sign can be seen.

Expected Result:

The "Trial: 30 days left" sign, should be displayed on Concierge chat preview.

Actual Result:

The "Trial: 30 days left" sign, is displayed on preview of #Admins room of the first created workspace, instead of on Concierge chat´s preview.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915847868020875229
• Upwork Job ID: 1915847868020875229
• Last Price Increase: 2025-04-25

Issue Owner

Current Issue Owner: @QichenZhu

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ashuvssut]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 12:19:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Trial: 30 days left" sign, should be displayed on Concierge chat preview instead of #admin's report which was created when MANAGE_TEAM onboarding intent was selected during onboarding process

What is the root cause of that problem?

We are check if the onboarding intent was MANAGE_TEAM. That is, we check onboardingPurposeSelected === "newDotManageTeam" (Check this PR which added it)

if MANAGE_TEAM onboarding intent was selected when onboarding, then we show the FreeTrial banner on the #admin report

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 67 in 717b77a

const isChatUsedForOnboarding = isChatUsedForOnboardingReportUtils(report, introSelected?.choice);

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 294 in 717b77a

{isChatUsedForOnboarding && <FreeTrial badgeStyles={[styles.mnh0, styles.pl2, styles.pr2, styles.ml1]} />}

What changes do you think we should make in order to solve the problem?

Currently we only show FreeTrial badge on #admin report when onboarding intent was selected as MANAGE_TEAM

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 294 in 717b77a

{isChatUsedForOnboarding && <FreeTrial badgeStyles={[styles.mnh0, styles.pl2, styles.pr2, styles.ml1]} />}

Instead of that, we should show FreeTrial on a Concierge chat report only

{isConciergeChatReport(report) && <FreeTrial badgeStyles={[styles.mnh0, styles.pl2, styles.pr2, styles.ml1]} />}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[marcaaron]

I am approaching this issue with total confusion. Did @c3024 write the test steps incorrectly?

The PR description says:

This PR adds the logic to display the "Free trial" banner and button in header on #admins room for users selecting "Manage my team's expenses" intent during onboarding."

Which is the "actual result"

The "Trial: 30 days left" sign, is displayed on preview of #Admins room of the first created workspace, instead of on Concierge chat´s preview.

I'm gonna pop the blocker off this because I don't think this one is that bad in any case and I'd like to deploy today.