[Due for payment 2025-05-22] [$250] Expense Report Identification Footer Displaying Incorrectly in Group Chat Details Panel

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a group chat
2. Click on the header to view the details
3. Observe the details

Expected Result:

The expense report identification footer should only appear in relevant contexts

Actual Result:

The expense report identification footer is being displayed in the details pane of a group chat

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021916886337632336941
• Upwork Job ID: 1916886337632336941
• Last Price Increase: 2025-05-05
• Automatic offers:
• nkdengineer | Contributor | 107191538

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-22 17:38:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense report identification footer is being displayed in the details pane of a group chat

What is the root cause of that problem?

we are displaying the footer here

App/src/pages/ReportDetailsPage.tsx

Lines 1075 to 1090 in 7368027

	<FixedFooter style={[styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, styles.pt5]}>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.gap3]}>
	<TextWithCopy
	copyValue={base62ReportID}
	style={styles.textMicroSupporting}
	>
	{`${translate('common.reportID')}: ${base62ReportID}`}
	</TextWithCopy>
	<TextWithCopy
	copyValue={report.reportID}
	style={styles.textMicroSupporting}
	>
	{`${translate('common.longID')}: ${report.reportID}`}
	</TextWithCopy>
	</View>
	</FixedFooter>

What changes do you think we should make in order to solve the problem?

We can only show the footer if (isInvoiceReport || isExpenseReport) && !isIOURequest(report) or we can use the condition (isInvoiceReport || isExpenseReport) && (!isIOUReport || !isTransactionThread(report?.parentReportAction))

App/src/libs/ReportUtils.ts

Lines 2102 to 2109 in b1b95a3

	function isIOURequest(report: OnyxInputOrEntry<Report>): boolean {
	if (isThread(report)) {
	const parentReportAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`]?.[report.parentReportActionID];
	const parentReport = getReport(report?.parentReportID, allReports);
	return isIOUReport(parentReport) && !isEmptyObject(parentReportAction) && isTransactionThread(parentReportAction);
	}
	return false;
	}

Note: We can add other conditions to show the footer

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Create a util function named isFinancialReportsForBusinesses and use this instead of isExpenseReport

  function isFinancialReportsForBusinesses(report: OnyxEntry<Report>): boolean {
      return report?.type === CONST.REPORT.TYPE.EXPENSE || report?.type === CONST.REPORT.TYPE.INVOICE;
  }

This condition will be isFinancialReportsForBusinesses

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[shawnborton]

To clarify, I think we only want to show this for expense reports and invoices right now.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense Report Identification Footer Displaying Incorrectly in Group Chat Details Panel

What is the root cause of that problem?

• The report identification is rendered without any condition.

App/src/pages/ReportDetailsPage.tsx

Lines 1075 to 1090 in fdac720

	<FixedFooter style={[styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, styles.pt5]}>
	<View style={[styles.flexRow, styles.alignItemsCenter, styles.gap3]}>
	<TextWithCopy
	copyValue={base62ReportID}
	style={styles.textMicroSupporting}
	>
	{`${translate('common.reportID')}: ${base62ReportID}`}
	</TextWithCopy>
	<TextWithCopy
	copyValue={report.reportID}
	style={styles.textMicroSupporting}
	>
	{`${translate('common.longID')}: ${report.reportID}`}
	</TextWithCopy>
	</View>
	</FixedFooter>

What changes do you think we should make in order to solve the problem?

• We need to add a condition (isExpenseReport(report) || isInvoiceReport(report)) before rendering the identification footer.

{(isExpenseReport || isInvoiceReport) && (
    <FixedFooter style={[styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, styles.pt5]}>
        <View style={[styles.flexRow, styles.alignItemsCenter, styles.gap3]}>
            <TextWithCopy
                copyValue={base62ReportID}
                style={styles.textMicroSupporting}
            >
                {`${translate('common.reportID')}: ${base62ReportID}`}
            </TextWithCopy>
            <TextWithCopy
                copyValue={report.reportID}
                style={styles.textMicroSupporting}
            >
                {`${translate('common.longID')}: ${report.reportID}`}
            </TextWithCopy>
        </View>
    </FixedFooter>
)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A -- UI Issue

What alternative solutions did you explore? (Optional)

N/A

Result

[nkdengineer]

Updated proposal to add the condition match with expected here

[melvin-bot]

@CortneyOfstad Eep! 4 days overdue now. Issues have feelings too...

[CortneyOfstad]

Getting eyes on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021916886337632336941