[Due for payment 2025-06-17] Hide option 1-10 in onboarding company size selection if user was routed to app via smb

[chiragsalian]

Feature Improvement

Part of the project

Main issue: https://github.com/Expensify/Expensify/issues/476894
Doc section: N/A, discovered during testing - https://github.com/Expensify/Web-Expensify/pull/46481#issuecomment-2902747604
Project: https://github.com/orgs/Expensify/projects/193/views/1

Manual Test Steps

1. Go to oldDot, www.expensify.com
2. Select signup option "Control", enter an email. Click "Get Started"
   
3. You will be redirected to newDot, with the ONBOARDING_SIGNUP_QUALIFIERS as smb - code
4. In newDot you will see the company size selection onboarding
   

Expected

1. In the option list 1-10 should not show up because the user during signup has already selected company size is 10+.
   

Actual

1. The option list shows 1-10.

Issue Owner

Current Issue Owner: @roryabraham

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-28 14:01:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hide option 1-10 in onboarding company size selection if user was routed to app via smb

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

We should filter out the 1-10 option here if the user was routed to app via smb.

const [onboardingValues] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {canBeMissing: true});
const isSmb = onboardingValues?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.SMB;
return Object.values(CONST.ONBOARDING_COMPANY_SIZE).filter((size) => !isSmb || size !== CONST.ONBOARDING_COMPANY_SIZE.MICRO).map((companySize): OnboardingListItem => {

App/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

Line 36 in f90638a

return Object.values(CONST.ONBOARDING_COMPANY_SIZE).map((companySize): OnboardingListItem => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

It's just a minor UI change, I think we can skip the test here. If we want to add the test, we can render OnboardingEmployees and verify that the 1-10 option isn't displayed on the screen if the signupQualifier is smb and vice versa

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[abzokhattab]

Quick question — if the employee size is already set during sign-up, why do we show the list again? I think it might be a better UX to skip the employee size step altogether since the value is already provided.

What do you think, @chiragsalian?

[chiragsalian]

if the employee size is already set during sign-up, why do we show the list again?

If its already set up we don't need to show the list again. But realistically i don't know how this would happen.
This only normally happens for vsb (very small business) flow and in that flow we set the company size here.

But for smb (small business) during signup the user mentions 10+,

but we've not captured exactly what besides 10+ so in newdot we should show these,

[abzokhattab]

I see got you ... maybe for the Manage expenses for a small team it would make sense to skip the list in this case

[chiragsalian]

maybe for the Manage expenses for a small team it would make sense to skip the list in this case

Yup, that already happens.

[QichenZhu]

Thanks @thelullabyy for the proposal. Could you add test scenarios similar to https://github.com/Expensify/App/blob/main/tests/ui/WorkEmailOnboarding.tsx?

[thelullabyy]

@QichenZhu Updated the test.