[Due for payment 2025-06-19] [$250] Expense report - 'Comments' sub-header is not displayed in the chat.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.54-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6184971
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: All platforms
App Component: Other

Action Performed:

1. Go to ND https://staging.new.expensify.com/
2. Loggin with a expensifail account
3. Create a new WS > Enable workflows in 'More Features' if it is disabled
4. Go to the WS chat created
5. Click on + button (create) within the chat > Create Report
6. Open the Expense Report you created on the previously step.
7. Send a message.

Expected Result:

'Comments' sub-header should be displayed above the comment.

Actual Result:

'Comments' sub-header is not displayed above the first comment.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928524875839888926
• Upwork Job ID: 1928524875839888926
• Last Price Increase: 2025-05-30
• Automatic offers:
• daledah | Contributor | 107616047

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-29 18:22:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Comments' sub-header is not displayed above the first comment.

What is the root cause of that problem?

We only display the sub header when there's transactions

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 199 in 3fa3aba

return !isEmpty(transactions) ? (

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 318 to 324 in 3fa3aba

	<Animated.Text
	style={[styles.textLabelSupporting]}
	entering={hasComments ? undefined : FadeIn}
	exiting={FadeOut}
	>
	{hasComments || isLoadingReportActions ? translate('common.comments') : ''}
	</Animated.Text>

What changes do you think we should make in order to solve the problem?

We should display only the "Comments" sub header when there's comment and no transactions

Add here

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 352 in 3fa3aba

<SearchMoneyRequestReportEmptyState />

{hasComments && (
                <View style={[styles.dFlex, styles.flexRow, listHorizontalPadding, styles.justifyContentBetween, styles.mb2]}>
                    <Animated.Text
                        style={[styles.textLabelSupporting]}
                        entering={undefined}
                        exiting={FadeOut}
                    >
                        {translate('common.comments')}
                    </Animated.Text>
                </View>
            )}

Or move this sub header to outside of !isEmpty(transactions) check.

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 329 to 343 in 649eff9

	<View style={[styles.dFlex, styles.flexRow, listHorizontalPadding, styles.justifyContentBetween, styles.mb2]}>
	<Animated.Text
	style={[styles.textLabelSupporting]}
	entering={hasComments ? undefined : FadeIn}
	exiting={FadeOut}
	>
	{hasComments || isLoadingReportActions ? translate('common.comments') : ''}
	</Animated.Text>
	<View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pr3]}>
	<Text style={[styles.mr3, styles.textLabelSupporting]}>{translate('common.total')}</Text>
	<Text style={[shouldUseNarrowLayout ? styles.mnw64p : styles.mnw100p, styles.textAlignRight, styles.textBold, pendingActionsOpacity]}>
	{convertToDisplayString(totalDisplaySpend, report?.currency)}
	</Text>
	</View>
	</View>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, UI issue

What alternative solutions did you explore? (Optional)

We can extract this sub header:

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 317 to 331 in 3fa3aba

	<View style={[styles.dFlex, styles.flexRow, listHorizontalPadding, styles.justifyContentBetween, styles.mb2]}>
	<Animated.Text
	style={[styles.textLabelSupporting]}
	entering={hasComments ? undefined : FadeIn}
	exiting={FadeOut}
	>
	{hasComments || isLoadingReportActions ? translate('common.comments') : ''}
	</Animated.Text>
	<View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pr3]}>
	<Text style={[styles.mr3, styles.textLabelSupporting]}>{translate('common.total')}</Text>
	<Text style={[shouldUseNarrowLayout ? styles.mnw64p : styles.mnw100p, styles.textAlignRight, styles.textBold, pendingActionsOpacity]}>
	{convertToDisplayString(totalDisplaySpend, report?.currency)}
	</Text>
	</View>
	</View>

Into a new component. Implement like below

function SubHeader({report, hasComments, isLoadingInitialReportActions: isLoadingReportActions, transactions}: MoneyRequestReportTransactionListProps) {
    const {totalDisplaySpend} = getMoneyRequestSpendBreakdown(report);
    const styles = useThemeStyles();
    const {translate} = useLocalize();
    const {shouldUseNarrowLayout} = useResponsiveLayout();

    const pendingActionsOpacity = useMemo(() => {
        const pendingAction = transactions.some(getTransactionPendingAction);
        return pendingAction && styles.opacitySemiTransparent;
    }, [styles.opacitySemiTransparent, transactions]);

    const isTransactionEmpty = isEmpty(transactions);
    const shouldShowComments = hasComments || (!isEmpty(transactions) && isLoadingReportActions);

    if (isTransactionEmpty && !hasComments) {
        return null;
    }

    return (
        <View style={[styles.dFlex, styles.flexRow, styles.ph5, styles.justifyContentBetween, styles.mb2]}>
            <Animated.Text
                style={[styles.textLabelSupporting]}
                entering={hasComments ? undefined : FadeIn}
                exiting={FadeOut}
            >
                {shouldShowComments ? translate('common.comments') : ''}
            </Animated.Text>
            {!isTransactionEmpty && (
                <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.pr3]}>
                    <Text style={[styles.mr3, styles.textLabelSupporting]}>{translate('common.total')}</Text>
                    <Text style={[shouldUseNarrowLayout ? styles.mnw64p : styles.mnw100p, styles.textAlignRight, styles.textBold, pendingActionsOpacity]}>
                        {convertToDisplayString(totalDisplaySpend, report?.currency)}
                    </Text>
                </View>
            )}
        </View>
    );
}

Then add it after here

App/src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

Line 624 in 5f9d2d2

/>

<SubHeader
          report={report}
          transactions={transactions}
          hasComments={reportHasComments}
          isLoadingInitialReportActions={isLoadingInitialReportActions}
/>

There's also a weird behaviour that I'm not sure if it's a bug: If there's no comments, then the "Comments" sub header will display briefly when loading then disappears. We can discuss this later if needed.

Screen.Recording.2025-05-30.at.01.20.15.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928524875839888926

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@daledah Thanks for the proposal. I think we should extract the view logic outside the !isEmpty(transactions) condition. Can you please update your proposal?

[OfstadC]

Please note - I'll be OoO through Friday. If this issue needs BZ action while I'm out, please remove me, reapply the BZ label so another BZ member is assigned, and than re-add me as an assignee so I can check back in on Monday. Thank you! 😃

[s77rt]

Not overdue ^