[Due for payment 2025-07-18] [$250] Expense Room Shortcut in Workspaces Leads to Undefined Link (Hmm...It's not here)

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): #Convert

Action Performed:

1. Log into the app
2. Navigate to a workspace that you do not own
3. Click into the workspace
4. Observe that the Expense Room is grayed out and not loading
5. Click the Expense Room shortcut
6. You are redirected to a broken page with an “Hmm.. it’s not here” message and an undefined URL
7. Navigate back to the Workspace Editor
8. The Expense Room now appears correctly and is accessible.

Expected Result:

The Expense Room shortcut should work immediately, even on first load, and should not lead to an undefined link.

Actual Result:

Initially, the shortcut leads to a broken page with an undefined link. Only after returning to the workspace editor does the Expense Room display and function properly.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2025-07-01_14-55-05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940450738965959332
• Upwork Job ID: 1940450738965959332
• Last Price Increase: 2025-07-02
• Automatic offers:
• thelullabyy | Contributor | 107904043

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[hungvu193]

I can reproduce this issue consistently with these steps:

1. Create new workspace
2. Reset cache and restart
3. Go to workspace
4. Click on workspace room

trim.B0A627D9-6E63-40E4-981D-9060CF82837C.MOV

@clarajones-expensify Please assign me to this issue per

https://expensify.enterprise.slack.com/archives/C02NK2DQWUX/p1751461720123509

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Expense Room Shortcut in Workspaces Leads to Undefined Link (Hmm...It's not here)

What is the root cause of that problem?

The issue stems from the logic used to retrieve the policy expense chat:

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 128 in a15c7d9

const currentUserPolicyExpenseChatReportID = getPolicyExpenseChat(accountID, policy?.id)?.reportID;

This logic depends on the reports data, which is outdated at the time of execution. As a result, the policy expense chat is returned as undefined, even though the correct data is already available in Onyx storage.

What changes do you think we should make in order to solve the problem?

• Update getPolicyExpenseChat to accept a third parameter, allReports, which is sourced via Onyx:

const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});

• In the function located here:

App/src/libs/ReportUtils.ts

Lines 8333 to 8346 in 022fa2e

	function getPolicyExpenseChat(ownerAccountID: number | undefined, policyID: string | undefined): OnyxEntry<Report> {
	if (!ownerAccountID || !policyID) {
	return;
	}
	return Object.values(allReports ?? {}).find((report: OnyxEntry<Report>) => {
	// If the report has been deleted, then skip it
	if (!report) {
	return false;
	}
	return report.policyID === policyID && isPolicyExpenseChat(report) && !isThread(report) && report.ownerAccountID === ownerAccountID;
	});
	}

we should use the allReports passed as a parameter instead of relying on the allReports from Onyx.connect.

• Update all other usages of getPolicyExpenseChat accordingly to provide the new allReports argument where needed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Add tests for getPolicyExpenseChat that verify behavior when the allReports parameter is provided directly, particularly when Onyx-connected reports are stale.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940450738965959332