[Due for payment 2025-07-22] [$250] Optimize useSearchHighlightAndScroll

[mountiny]

coming from here

Background

Bottom tabs are one of the most frequently used and performance-critical areas of the app. Interactions must feel instant to preserve a smooth user experience.

Problem

The useSearchHighlightAndScroll hook runs multiple heavy iterations over entire collections inside a useEffect. Due to a large dependency array, this effect re-runs often - triggering expensive recalculations whenever any of them change. As a result, navigating to or from the Search screen becomes sluggish, especially on larger accounts.

Solution

Optimize collection lookups by replacing .includes with a Set and using .has() for O(1) checks. This change dramatically reduces the cost of useEffect executions.

Measurements of the affected useEffect (Jason’s state):

• Before: 2.92s
• After: 56ms

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021943045609459074645
• Upwork Job ID: 1943045609459074645
• Last Price Increase: 2025-07-09

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021943045609459074645

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.