-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/actions/IOU.ts #66508
Copy link
Copy link
Open
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.Item broken or needs improvement.MonthlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/actions/IOU.ts
- Onyx Key:
ONYXKEYS.PERSONAL_DETAILS_LIST - Reference:
Line 632: ONYXKEYS.PERSONAL_DETAILS_LIST
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Reactions are currently unavailable
Metadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.Item broken or needs improvement.MonthlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
Type
Fields
Give feedbackNo fields configured for issues without a type.