[Due for payment 2025-08-13] Remove call to `getReportNameValuePairs()` in method `getIcons ` from `ReportUtils.ts`

[tgolen]

This is part of #59961 and will ensure that the function is a pure function.

No proposals are necessary for this.

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[DylanDylann]

🔔 Note for Contributors: Please ensure that you are responsible in the PR phase to try to get it done soon

The function getIcons() is not a pure function because it references the report's NVPs from a global variable here. This is considered an anti-pattern that we are actively working to eliminate.

✅ Your Task

1. Verify that a unit test exists for getIcons() in its current form. If it doesn't, create one — and aim for high-quality, thorough coverage.

2. Refactor getIcons() into a pure function, and introduce a new parameter: isReportArchived = false (It is recommended to use useReportIsArchived to get isReportArchived). And update all instances in the codebase where getIcons() is called to accommodate the new isReportArchived parameter.

⚠️ Best Practices to Follow

1. Avoid adding new global references to data via Onyx.connect.
2. Avoid using isArchivedReport(nameValuePairs) unless absolutely necessary.
3. Prefer fetching data in a UI component, then pass it down via parameters.
4. Consider using the useReportIsArchived() React hook — it’s designed for this.
5. Before making changes, check if the report's NVPs are already available or if isReportArchived is already calculated or passed.

[Krishna2323]

@DylanDylann, I have read the guidelines for this issue. I would like to work on this.

[DylanDylann]

@Krishna2323, I see you have some pending tasks now. Are you confident that you can speed this issue up and be responsive in the PR phase?

[Krishna2323]

I see you have some pending tasks now.

I only have a pending task on only one PR, all the other PRs are in completed, just need to add recording. I'm on them and trying to finish those with few hours.